fix #4 : use float instead of string for fps when present

Author: bernard-ng

.github/workflows/lint.yaml

@@ -1,21 +1,40 @@
-name: Lint
+name: Coding standards
 on: [push]
 jobs:
   lint:
-    name: PHP Lint
+    name: Coding standards
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ '8.2', '8.3' ]
+
     steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.1
+          php-version: ${{ matrix.php }}
+          tools: composer:v2
+
+      - name: Setup cache
+        run: echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
 
-      - name: Cache Composer dependencies
+      - name: Cache dependencies installed with composer
         uses: actions/cache@v2
         with:
-          path: /tmp/composer-cache
-          key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
+            path: ${{ env.COMPOSER_CACHE_DIR }}
+            key: php${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
+            restore-keys: |
+              php${{ matrix.php }}-composer-latest-
+
+      - name: Update composer
+        run: composer self-update
+
+      - name: Install dependencies with composer
+        run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader --ansi
 
-      - uses: actions/checkout@master
-      - name: lint
+      - name: Run code quality analysis
         run: make lint

.github/workflows/test.yaml

@@ -1,21 +1,40 @@
-name: Test
+name: Tests
 on: [push]
 jobs:
-    lint:
-        name: PHP Test
-        runs-on: ubuntu-latest
-        steps:
-            - name: Setup PHP
-              uses: shivammathur/setup-php@v2
-              with:
-                  php-version: 8.1
+  test:
+    name: Tests
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ '8.2', '8.3' ]
 
-            - name: Cache Composer dependencies
-              uses: actions/cache@v2
-              with:
-                  path: /tmp/composer-cache
-                  key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
 
-            - uses: actions/checkout@master
-            - name: test
-              run: make test
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+            php-version: ${{ matrix.php }}
+            tools: composer:v2
+
+      - name: Setup cache
+        run: echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
+
+      - name: Cache dependencies installed with composer
+        uses: actions/cache@v2
+        with:
+            path: ${{ env.COMPOSER_CACHE_DIR }}
+            key: php${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
+            restore-keys: |
+                php${{ matrix.php }}-composer-latest-
+
+      - name: Update composer
+        run: composer self-update
+
+      - name: Install dependencies with composer
+        run: composer install --prefer-dist --no-interaction --no-progress --optimize-autoloader --ansi
+
+      - name: Run tests
+        run: make test

Makefile

@@ -1,20 +1,5 @@
 .DEFAULT_GOAL := help
 
-# -----------------------------------
-# Variables
-# -----------------------------------
-is_docker := $(shell docker info > /dev/null 2>&1 && echo 1)
-user := $(shell id -u)
-group := $(shell id -g)
-
-ifeq ($(is_docker), 1)
-	php := USER_ID=$(user) GROUP_ID=$(group) docker-compose run --rm --no-deps php
-	composer := $(php) composer
-else
-	php := php
-	composer := composer
-endif
-
 # -----------------------------------
 # Recipes
 # -----------------------------------
@@ -24,17 +9,17 @@ help: ## affiche cet aide
 
 .PHONY: lint
 lint: vendor/autoload.php ## affiche les erreurs de formatage de code
-	$(php) vendor/bin/ecs
-	$(php) vendor/bin/phpstan
+	php vendor/bin/ecs
+	php vendor/bin/phpstan
 
 .PHONY: test
 test: vendor/autoload.php ## lance les tests
-	$(php) vendor/bin/phpunit
+	php vendor/bin/phpunit
 
 .PHONY: lint-fix
 lint-fix: vendor/autoload.php ## corrige les erreurs de formatage de code
-	$(php) vendor/bin/ecs --fix
+	php vendor/bin/ecs --fix
 
 vendor/autoload.php: composer.lock # installe les dépendances PHP
-	$(composer) update
-	$(composer) dump-autoload
+	composer update
+	composer dump-autoload

composer.json

@@ -34,7 +34,7 @@
         "symfony/var-dumper": "^6.1|^7.0"
     },
     "require": {
-        "php": ">=8.1",
+        "php": ">=8.2",
         "symfony/http-client": "^6.1|^7.0",
         "symfony/serializer": "^6.1|^7.0",
         "symfony/property-access": "^6.1|^7.0",

src/Data/VideoFile.php

@@ -46,7 +46,7 @@ final class VideoFile
     public string $link;
 
     /**
-     * @var string|null frame rate of the video_file.
+     * @var float|null frame rate of the video_file.
      */
-    public ?string $fps = null;
+    public ?float $fps = null;
 }

tests/responses/video.json

@@ -17,7 +17,8 @@
       "file_type": "video/mp4",
       "width": 1080,
       "height": 1920,
-      "link": "https://player.vimeo.com/external/342571552.hd.mp4?s=6aa6f164de3812abadff3dde86d19f7a074a8a66&profile_id=175&oauth2_token_id=57447761"
+      "link": "https://player.vimeo.com/external/342571552.hd.mp4?s=6aa6f164de3812abadff3dde86d19f7a074a8a66&profile_id=175&oauth2_token_id=57447761",
+      "fps": 30
     },
     {
       "id": 125005,