Skip to content

fix: deselecting group chip reselects All teams#543

Closed
piyush140104 wants to merge 1 commit into
devsecopsmaturitymodel:mainfrom
piyush140104:fix/team-group-chip-deselect
Closed

fix: deselecting group chip reselects All teams#543
piyush140104 wants to merge 1 commit into
devsecopsmaturitymodel:mainfrom
piyush140104:fix/team-group-chip-deselect

Conversation

@piyush140104

@piyush140104 piyush140104 commented Apr 7, 2026

Copy link
Copy Markdown

Problem

On the heatmap page, once a team group chip (e.g. Customer, Internal) is selected there is no way to deselect it. Clicking it again does nothing and the chip stays permanently stuck in the selected state.

Root Cause

In toggleTeamGroupFilter() inside circular-heatmap.component.ts, the else branch which runs when the chip is already selected only had a console.log and returned immediately. There was no deselection logic.

Fix
Replaced chip.toggleSelected() calls with data driven logic using filtersTeamGroups as the single source of truth since the template already binds [selected] to filtersTeamGroups[group.key]. Selecting a group chip now deselects all other group chips first. Deselecting a group chip clears all team filters, resets hasTeamsFilter and automatically reselects the All teams chip. setVisibleTeams() is now called once after the loop instead of inside it.

Reviewers
@vbakke @wurstbrot

Closes #524

@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. 📆 It will be closed automatically in two weeks if no further activity occurs.

@github-actions github-actions Bot added the Stale label May 14, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

This PR was closed because it has been stalled for 20 days with no activity.

@github-actions github-actions Bot closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TeamGroup filter chip cannot be deselected once selected

1 participant