fix: prevent nil map panic when docker-compose.yaml has top-level name field#3204
Open
raman1236 wants to merge 1 commit intodevspace-sh:mainfrom
Open
fix: prevent nil map panic when docker-compose.yaml has top-level name field#3204raman1236 wants to merge 1 commit intodevspace-sh:mainfrom
raman1236 wants to merge 1 commit intodevspace-sh:mainfrom
Conversation
…e field When a docker-compose.yaml includes a top-level 'name:' field, the compose-go loader attempts to assign to ConfigDetails.Environment which is nil, causing a panic. Initialize the Environment map to an empty map before calling the loader. Fixes devspace-sh#2970
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2970
When a
docker-compose.yamlincludes a top-levelname:field (e.g.name: myproject),devspace initpanics with:Root Cause
In
pkg/devspace/compose/manager.go,LoadDockerComposeProjectpasses aConfigDetailsstruct to the compose-go loader without initializing theEnvironmentfield. When the compose file has aname:field, the loader tries to write toconfigDetails.Environment(invendor/.../loader/loader.goline 218), which isnil.Fix
Initialize
Environmentto an empty map in theConfigDetailsstruct passed tocomposeloader.Load().Testing
named_projecttest case underpkg/devspace/compose/testdata/with adocker-compose.yamlcontainingname: myproject