Fix ambiguous helper calls in strict mode

theodorejb · theodorejb · commit 3860588155a6 · 2026-04-09T18:36:30.000-05:00
diff --git a/src/Compiler.php b/src/Compiler.php
@@ -227,7 +227,7 @@ private function classifySexpr(?string $simpleName, array $params, ?Hash $hash):
             return SexprType::Helper;
         }
         if ($simpleName !== null) {
-            return SexprType::Ambiguous;
+            return $this->context->options->knownHelpersOnly ? SexprType::Simple : SexprType::Ambiguous;
         }
         return SexprType::Simple;
     }
@@ -485,16 +485,16 @@ private function PartialBlockStatement(PartialBlockStatement $statement): string
 
         if ($partialName !== null && !$found) {
             // Register the block body as a fallback partial only if no runtime partial with this name exists yet.
-            $parts[] = "(isset(\$cx->inlinePartials[$p]) || isset(\$cx->partials[$p]) ? '' : " . self::getRuntimeFunc('in', "\$cx, $p, $bodyClosure") . ')';
+            $parts[] = "(isset(\$cx->inlinePartials[$p]) || isset(\$cx->partials[$p]) ? '' : "
+                . self::getRuntimeFunc('in', "\$cx, $p, $bodyClosure") . ')';
         }
         $parts[] = self::getRuntimeFunc('p', "\$cx, $p, $vars, '', $bodyClosure");
         return implode('.', $parts);
     }
 
     private function MustacheStatement(MustacheStatement $mustache): string
     {
-        $raw = !$mustache->escaped || $this->context->options->noEscape;
-        $fn = $raw ? 'raw' : 'encq';
+        $fn = (!$mustache->escaped || $this->context->options->noEscape) ? 'raw' : 'encq';
         $path = $mustache->path;
 
         // SubExpression path: {{(path args)}} — always a direct helper call result
@@ -512,27 +512,38 @@ private function MustacheStatement(MustacheStatement $mustache): string
             return self::getRuntimeFunc($fn, $call);
         }
 
-        if ($helperName !== null && $type === SexprType::Ambiguous && !$this->context->options->strict) {
+        if ($type === SexprType::Ambiguous) {
+            assert($helperName !== null);
             $escapedKey = self::quote($helperName);
             $isData = $path instanceof PathExpression && $path->data;
-            if ($this->context->options->knownHelpersOnly) {
-                $lookup = $isData ? "\$cx->data[$escapedKey] ?? null" : self::getRuntimeFunc('cv', "\$in, $escapedKey");
-                return self::getRuntimeFunc($fn, $lookup);
-            }
             $scope = $isData ? '$cx->data' : '$in';
-            $hvArgs = "\$cx, $escapedKey, $scope" . ($this->context->options->assumeObjects ? ', true' : '');
+            $hvArgs = "\$cx, $escapedKey, $scope";
+            if ($this->context->options->assumeObjects) {
+                $hvArgs .= ', true';
+            } elseif ($this->context->options->strict) {
+                $hvArgs .= ', false, true';
+            }
             return self::getRuntimeFunc($fn, self::getRuntimeFunc('hv', $hvArgs));
         }
 
-        // Simple: direct path lookup
+        // Simple: direct path lookup with lambda resolution.
+        // For knownHelpersOnly bare identifiers (single-segment, non-data): use cv() to pass the
+        // current context to any Closure, mirroring JS fn.call(context) where context is `this`.
+        // For all other simple paths (multi-segment, scoped, depth, data): use dv() with zero args,
+        // matching HBS.js container.lambda which also passes no positional arguments.
         if ($path instanceof PathExpression) {
-            return self::getRuntimeFunc($fn, self::getRuntimeFunc('dv', $this->PathExpression($path)));
+            if ($helperName !== null && !$path->data && $this->context->options->knownHelpersOnly) {
+                $cvArgs = '$in, ' . self::quote($helperName) . ($this->context->options->strict ? ', true' : '');
+                return self::getRuntimeFunc($fn, self::getRuntimeFunc('cv', $cvArgs));
+            }
+            $expression = $this->PathExpression($path);
+        } else {
+            // Literal in simple position: same lambda resolution as PathExpression above.
+            $literalKey = $this->getLiteralKeyName($path);
+            $expression = $this->compileModeAwareLookup('$in', [$literalKey], $literalKey);
         }
 
-        // Literal in simple/fallthrough position (strict, assumeObjects, or knownHelpersOnly):
-        // compile as a direct context lookup using the normalized key name.
-        $literalKey = $this->getLiteralKeyName($path);
-        return self::getRuntimeFunc($fn, $this->compileModeAwareLookup('$in', [$literalKey], $literalKey));
+        return self::getRuntimeFunc($fn, self::getRuntimeFunc('dv', $expression));
     }
 
     // ── Expressions ─────────────────────────────────────────────────
@@ -547,26 +558,24 @@ private function SubExpression(SubExpression $expression): string
         return $this->compileHelperCall($helperName, $path, $expression->params, $expression->hash);
     }
 
-    private function PathExpression(PathExpression $expression): string
+    private function PathExpression(PathExpression $path): string
     {
-        $data = $expression->data;
-        $depth = $expression->depth;
-        $parts = $expression->parts;
+        $data = $path->data;
+        $depth = $path->depth;
 
         // When the path head is a SubExpression (e.g. (helper).foo.bar), compile the
         // sub-expression as the base and use the string tail as the remaining key accesses.
-        $hasSubExprHead = $expression->head instanceof SubExpression;
+        $hasSubExprHead = $path->head instanceof SubExpression;
         if ($hasSubExprHead) {
-            $base = '(' . $this->SubExpression($expression->head) . ')';
-            $stringParts = $expression->tail;
+            $base = '(' . $this->SubExpression($path->head) . ')';
+            $stringParts = $path->tail;
         } else {
             $base = $this->buildBasePath($data, $depth);
-            /** @var string[] $parts */
-            $stringParts = $parts;
+            /** @var string[] $stringParts */
+            $stringParts = $path->parts;
         }
 
-        // `this` with no parts or empty parts
-        if (($expression->this_ && !$parts) || !$stringParts) {
+        if (!$stringParts) {
             return $base;
         }
 
@@ -578,8 +587,8 @@ private function PathExpression(PathExpression $expression): string
         $isLength = end($stringParts) === 'length';
 
         // Check block params (depth-0, non-data, non-scoped paths only, not SubExpression-headed)
-        if (!$hasSubExprHead && !$data && $depth === 0 && !self::scopedId($expression)) {
-            $bp = $this->lookupBlockParam($expression->head);
+        if (!$hasSubExprHead && !$data && $depth === 0 && !self::scopedId($path)) {
+            $bp = $this->lookupBlockParam($path->head);
             if ($bp !== null) {
                 [$bpDepth, $bpIndex] = $bp;
                 $bpBase = "\$blockParams[$bpDepth][$bpIndex]";
@@ -589,8 +598,8 @@ private function PathExpression(PathExpression $expression): string
                 }
 
                 // Skip the block param name since it has been resolved to a $blockParams index.
-                $keys = $isLength ? array_slice($expression->tail, 0, -1) : $expression->tail;
-                $lookup = $this->compileModeAwareLookup($bpBase, $keys, $expression->original);
+                $keys = $isLength ? array_slice($path->tail, 0, -1) : $path->tail;
+                $lookup = $this->compileModeAwareLookup($bpBase, $keys, $path->original);
                 return $isLength ? $this->buildLookupLength($lookup) : $lookup;
             }
         }
@@ -601,11 +610,11 @@ private function PathExpression(PathExpression $expression): string
         if ($isLength) {
             $partsExceptLength = array_slice($stringParts, 0, -1);
             return $this->buildLookupLength(
-                $this->compileModeAwareLookup($base, $partsExceptLength, $expression->original),
+                $this->compileModeAwareLookup($base, $partsExceptLength, $path->original),
             );
         }
 
-        return $this->compileModeAwareLookup($base, $stringParts, $expression->original);
+        return $this->compileModeAwareLookup($base, $stringParts, $path->original);
     }
 
     /**
diff --git a/src/Runtime.php b/src/Runtime.php
@@ -202,7 +202,7 @@ public static function createContext(mixed $context, array $options, array $comp
     }
 
     /**
-     * Invoke $v if it is a Closure; otherwise return $v as-is.
+     * Invoke $v without arguments if it is a Closure; otherwise return $v as-is.
      */
     public static function dv(mixed $v): mixed
     {
@@ -211,36 +211,42 @@ public static function dv(mixed $v): mixed
 
     /**
      * Context variable lookup without helper dispatch.
-     * Looks up $name in $_this; if the value is a Closure, invokes it with $_this as context.
-     * Used when helper dispatch is unnecessary: knownHelpersOnly mode (the compiler has already
-     * ruled out known helpers), and inlined if/unless conditions on single-segment paths.
+     * Looks up $name in $_this; if the value is a Closure, invokes it with $_this as a positional arg
+     * (PHP equivalent of JS fn.call(context), where context binds as `this` with no positional args).
+     * When $strict is true, throws for missing keys.
      *
      * @param mixed $_this current rendering context
      */
-    public static function cv(mixed &$_this, string $name): mixed
+    public static function cv(mixed &$_this, string $name, bool $strict = false): mixed
     {
-        $v = $_this[$name] ?? null;
+        $v = $strict ? static::strictLookup($_this, $name, $name) : ($_this[$name] ?? null);
         return $v instanceof Closure ? $v($_this) : $v;
     }
 
     /**
      * Helper-or-variable lookup for bare {{identifier}} expressions.
-     * Checks runtime helpers first, then context value, then helperMissing fallback.
+     * Checks runtime helpers first, then context value.
+     * In non-strict mode: falls back to helperMissing when the context value is null.
      * When $assumeObjects is true, uses nullCheck for context lookup (throws on null context).
+     * When $strict is true, uses strictLookup after the helper check (throws for missing keys; no helperMissing fallback).
      *
      * @param mixed $_this current rendering context
      */
-    public static function hv(RuntimeContext $cx, string $name, mixed &$_this, bool $assumeObjects = false): mixed
+    public static function hv(RuntimeContext $cx, string $name, mixed &$_this, bool $assumeObjects = false, bool $strict = false): mixed
     {
         $helper = $cx->helpers[$name] ?? null;
         if ($helper !== null) {
             return static::hbch($cx, $helper, $name, [], [], $_this);
         }
-        $value = $assumeObjects ? static::nullCheck($_this, $name) : ($_this[$name] ?? null);
-        if ($value === null || $value instanceof Closure) {
-            return static::hbch($cx, $value ?? $cx->helpers['helperMissing'], $name, [], [], $_this);
+        if ($strict) {
+            $value = static::strictLookup($_this, $name, $name);
+        } else {
+            $value = $assumeObjects ? static::nullCheck($_this, $name) : ($_this[$name] ?? null);
+            if ($value === null) {
+                return static::hbch($cx, $cx->helpers['helperMissing'], $name, [], [], $_this);
+            }
         }
-        return $value;
+        return $value instanceof Closure ? static::hbch($cx, $value, $name, [], [], $_this) : $value;
     }
 
     /**
diff --git a/tests/RegressionTest.php b/tests/RegressionTest.php
@@ -2233,6 +2233,13 @@ public static function missingDataProvider(): array
                 'data' => ['foo' => null],
                 'expected' => '',
             ],
+
+            'strict mode should invoke ambiguous helper not present in context data' => [
+                'template' => '{{greeting}}',
+                'options' => new Options(strict: true),
+                'helpers' => ['greeting' => fn() => 'Hello'],
+                'expected' => 'Hello',
+            ],
         ];
     }
 
