Skip to content

Commit 552cb79

Browse files
committed
feat: improve query parameter handling
1 parent 4b90169 commit 552cb79

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

pkg/currency/Service.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,12 @@ func (s *ServiceImpl) fetchRatesFromAPI(ctx context.Context, base string) (*Exch
143143
return nil, fmt.Errorf("failed to parse url: %w", err)
144144
}
145145
exchangeRateUrl := baseURl.JoinPath("latest.json")
146-
exchangeRateUrl.Query().Set("app_id", s.config.APIKey)
146+
queries := exchangeRateUrl.Query()
147+
queries.Set("app_id", s.config.APIKey)
147148
if base != USD {
148-
exchangeRateUrl.Query().Set("base", base)
149+
queries.Set("base", base)
149150
}
151+
exchangeRateUrl.RawQuery = queries.Encode()
150152
req, err := http.NewRequestWithContext(ctx, "GET", exchangeRateUrl.String(), nil)
151153
if err != nil {
152154
return nil, fmt.Errorf("failed to create request: %w", err)

wire_gen.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)