Refactor version comparison to use semver library

Replaced custom version parsing logic with the Masterminds/semver library for improved accuracy and maintainability. Added the dependency to `go.mod` and updated related files accordingly. This change ensures better handling of semantic versioning edge cases.

Author: Shivam-nagar23

api/RestHandler.go

@@ -18,6 +18,7 @@ package api
 
 import (
 	"encoding/json"
+	"github.com/Masterminds/semver"
 	util "github.com/devtron-labs/central-api/client"
 	"github.com/devtron-labs/central-api/common"
 	"github.com/devtron-labs/central-api/pkg"
@@ -259,36 +260,23 @@ func (impl *RestHandlerImpl) GetBuildpackMetadata(w http.ResponseWriter, r *http
 
 // isVersionNewer compares two version strings and returns true if v1 is newer than v2
 func isVersionNewer(v1, v2 string) bool {
-	// Remove 'v' prefix if present
-	v1 = strings.TrimPrefix(v1, "v")
-	v2 = strings.TrimPrefix(v2, "v")
-
-	// Split versions into components
-	v1Parts := strings.Split(v1, ".")
-	v2Parts := strings.Split(v2, ".")
+	// Ensure 'v' prefix is present for semver parsing
+	if !strings.HasPrefix(v1, "v") {
+		v1 = "v" + v1
+	}
+	if !strings.HasPrefix(v2, "v") {
+		v2 = "v" + v2
+	}
 
-	// Compare each component
-	for i := 0; i < len(v1Parts) && i < len(v2Parts); i++ {
-		v1Num, err1 := strconv.Atoi(v1Parts[i])
-		v2Num, err2 := strconv.Atoi(v2Parts[i])
+	// Parse versions
+	ver1, err1 := semver.NewVersion(v1)
+	ver2, err2 := semver.NewVersion(v2)
 
-		// If parts aren't numeric, fall back to string comparison
-		if err1 != nil || err2 != nil {
-			if v1Parts[i] > v2Parts[i] {
-				return true
-			} else if v1Parts[i] < v2Parts[i] {
-				return false
-			}
-			continue
-		}
-
-		if v1Num > v2Num {
-			return true
-		} else if v1Num < v2Num {
-			return false
-		}
+	// Fall back to string comparison if parsing fails
+	if err1 != nil || err2 != nil {
+		return strings.TrimPrefix(v1, "v") > strings.TrimPrefix(v2, "v")
 	}
 
-	// If all compared components are equal, the longer version is newer
-	return len(v1Parts) > len(v2Parts)
+	// Compare using semver
+	return ver1.GreaterThan(ver2)
 }

go.mod

@@ -3,6 +3,7 @@ module github.com/devtron-labs/central-api
 go 1.18
 
 require (
+	github.com/Masterminds/semver v1.5.0
 	github.com/caarlos0/env v3.5.0+incompatible
 	github.com/devtron-labs/common-lib v0.0.16-0.20240318063710-69cb957d019a
 	github.com/go-pg/pg v6.15.1+incompatible

go.sum

@@ -32,6 +32,8 @@ github.com/Azure/go-autorest/logger v0.2.1/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZ
 github.com/Azure/go-autorest/tracing v0.6.0 h1:TYi4+3m5t6K48TGI9AUdb+IzbnSxvnvUMfuitfgcfuo=
 github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
+github.com/Masterminds/semver v1.5.0 h1:H65muMkzWKEuNDnfl9d70GUjFniHKHRbFPGBuZ3QEww=
+github.com/Masterminds/semver v1.5.0/go.mod h1:MB6lktGJrhw8PrUyiEoblNEGEQ+RzHPF078ddwwvV3Y=
 github.com/aws/aws-sdk-go v1.44.116 h1:NpLIhcvLWXJZAEwvPj3TDHeqp7DleK6ZUVYyW01WNHY=
 github.com/aws/aws-sdk-go v1.44.116/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
 github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8=

vendor/modules.txt

@@ -45,6 +45,9 @@ github.com/Azure/go-autorest/logger
 # github.com/Azure/go-autorest/tracing v0.6.0
 ## explicit; go 1.12
 github.com/Azure/go-autorest/tracing
+# github.com/Masterminds/semver v1.5.0
+## explicit
+github.com/Masterminds/semver
 # github.com/aws/aws-sdk-go v1.44.116
 ## explicit; go 1.11
 github.com/aws/aws-sdk-go/aws