Skip to content

Commit cf9da27

Browse files
Refactor response slicing logic in RestHandler.
Reorganized conditions to ensure server version filtering occurs before slicing the response by size and offset. This enhances code readability and preserves logical consistency in response processing.
1 parent 8ffc512 commit cf9da27

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

api/RestHandler.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,7 @@ func (impl *RestHandlerImpl) GetReleases(w http.ResponseWriter, r *http.Request)
148148
impl.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
149149
return
150150
}
151-
152-
if size > 0 && len(serverVersion) == 0 {
153-
if offset+size <= len(response) {
154-
response = response[offset : offset+size]
155-
} else {
156-
response = response[offset:]
157-
}
158-
} else if len(serverVersion) > 0 {
151+
if len(serverVersion) > 0 {
159152
// get all releases of that version and above that version
160153
var filteredResponse []*common.Release
161154
for _, release := range response {
@@ -166,6 +159,14 @@ func (impl *RestHandlerImpl) GetReleases(w http.ResponseWriter, r *http.Request)
166159
}
167160
response = filteredResponse
168161
}
162+
163+
if size > 0 {
164+
if offset+size <= len(response) {
165+
response = response[offset : offset+size]
166+
} else {
167+
response = response[offset:]
168+
}
169+
}
169170
if len(response) == 0 {
170171
response = make([]*common.Release, 0)
171172
}

0 commit comments

Comments
 (0)