Skip to content

fix: table app count in app group listing css #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elessar1802 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: table app count in app group listing css #3075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ApplicationGroup/List/EnvironmentListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const EnvironmentNameCellComponent = ({ row, value }: TableCellComponentProps<En
const ApplicationCountCellComponent = ({ value }: TableCellComponentProps<EnvAppList, FiltersTypeEnum.URL>) => {
const count = (value as number) || 0
return (
<div>
<div className="flex left">
{count}&nbsp;
{count === 0 || count === 1 ? GROUP_LIST_HEADER.APPLICATION : GROUP_LIST_HEADER.APPLICATIONS}
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The singular/plural logic will render "0 Application" for a zero count due to count === 0 || count === 1. Typically 0 should use the plural label, so this should only be singular when count === 1.

Suggested change
{count === 0 || count === 1 ? GROUP_LIST_HEADER.APPLICATION : GROUP_LIST_HEADER.APPLICATIONS}
{count === 1 ? GROUP_LIST_HEADER.APPLICATION : GROUP_LIST_HEADER.APPLICATIONS}

Copilot uses AI. Check for mistakes.
</div>
Expand Down
Loading