Skip to content

Commit 0170291

Browse files
committed
chore: code feedback fixes
1 parent 730ab48 commit 0170291

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/Shared/Components/GenericInfoCard/GenericInfoCardListing.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ export const GenericInfoCardListing = ({
2323
emptyStateConfig,
2424
}: GenericInfoCardListingProps) => {
2525
const filteredList = useMemo(() => {
26+
const sanitizedList = list || []
2627
if (!searchKey || error) {
27-
return list
28+
return sanitizedList
2829
}
2930

3031
const loweredSearchKey = searchKey.toLowerCase()

src/Shared/Components/GenericInfoCard/GenericInfoListSkeleton.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import GenericInfoCard from './GenericInfoCard.component'
2+
import { GenericInfoListSkeletonProps } from './types'
23

3-
export const GenericInfoListSkeleton = (borderVariant) => (
4+
export const GenericInfoListSkeleton = ({ borderVariant }: GenericInfoListSkeletonProps) => (
45
<>
56
<GenericInfoCard isLoading borderVariant={borderVariant} />
67
<GenericInfoCard isLoading borderVariant={borderVariant} />

src/Shared/Components/GenericInfoCard/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,5 @@ export interface GenericInfoCardListingProps
6363
error?: APIResponseHandlerProps['error']
6464
isLoading?: boolean
6565
}
66+
67+
export interface GenericInfoListSkeletonProps extends Pick<GenericInfoCardProps, 'borderVariant'> {}

0 commit comments

Comments
 (0)