fix: review comments

Author: Amrit Kashyap Borah

src/Common/PopupMenu.tsx

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import React, { forwardRef, useEffect } from 'react'
+import React, { useEffect } from 'react'
 import { Modal } from './Modals/Modal'
 import { PopupMenuBodyType, PopupMenuButtonType, PopupMenuType } from './Types'
 
@@ -155,33 +155,19 @@ const PopupMenu = ({
     )
 }
 
-const Button = forwardRef(({
+const Button = ({
     children = null,
     disabled = false,
     rootClassName = '',
     tabIndex = 0,
     onHover = false,
     isKebab = false,
     dataTestId = '',
-}: PopupMenuButtonType, forwardedRef) => {
+}: PopupMenuButtonType) => {
     const { handleOpen, popupPosition, buttonRef, initialiseButtonWidth } = usePopupContext()
-
-    const refCallback = (node) => {
-        buttonRef.current = node
-
-        if (typeof forwardedRef === 'function') {
-            forwardedRef(node)
-            return
-        }
-
-        if (forwardedRef && typeof forwardedRef === 'object') {
-            forwardedRef.current = node
-        }
-    }
-
     return (
         <button
-            ref={refCallback}
+            ref={initialiseButtonWidth}
             type="button"
             tabIndex={tabIndex}
             disabled={disabled}
@@ -195,7 +181,7 @@ const Button = forwardRef(({
             {children}
         </button>
     )
-})
+}
 
 const Body = ({
     children = null,

src/Pages/ResourceBrowser/ResourceBrowser.Types.ts

@@ -14,11 +14,8 @@
  * limitations under the License.
  */
 
-import { Dispatch, ReactNode, RefObject, SetStateAction } from 'react'
-import { GroupBase } from 'react-select'
+import { ReactNode, RefObject } from 'react'
 
-import { ServerErrors } from '@Common/ServerError'
-import { SelectPickerOptionType } from '@Shared/Components'
 import { Nodes, NodeType } from '@Shared/types'
 
 export interface GVKType {
@@ -204,15 +201,6 @@ export interface GVKOptionValueType {
     apiVersion: string
 }
 
-export interface GetResourceRecommenderResourceListPropsType {
-    setShowAbsoluteValuesInResourceRecommender: Dispatch<SetStateAction<boolean>>
-    showAbsoluteValuesInResourceRecommender: boolean
-    gvkOptions: GroupBase<SelectPickerOptionType<GVKOptionValueType>>[]
-    areGVKOptionsLoading: boolean
-    reloadGVKOptions: () => void
-    gvkOptionsError: ServerErrors
-}
-
 export interface ResourceRecommenderActionMenuProps {
     children: ReactNode
     lastScannedOn: string

src/Shared/Components/BulkSelection/types.tsx

@@ -54,6 +54,9 @@ export interface BulkSelectionProps {
      */
     showChevronDownIcon?: boolean
     disabled?: boolean
+    /**
+     * If true, pressing the checkbox will select all items on page if list is not paginated
+     */
     selectAllIfNotPaginated?: boolean
 }
 

src/Shared/Components/Button/types.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { AnchorHTMLAttributes, ButtonHTMLAttributes, ReactElement } from 'react'
+import { AnchorHTMLAttributes, ButtonHTMLAttributes, ReactElement, Ref } from 'react'
 import { LinkProps } from 'react-router-dom'
 
 import { TooltipProps } from '@Common/Tooltip'
@@ -48,6 +48,7 @@ export enum ButtonComponentType {
 export type ButtonProps<ComponentType extends ButtonComponentType = ButtonComponentType.button> =
     (ComponentType extends ButtonComponentType.link
         ? {
+              ref?: Ref<HTMLAnchorElement>
               component: ButtonComponentType.link
               /**
                * Props for the link component
@@ -59,6 +60,7 @@ export type ButtonProps<ComponentType extends ButtonComponentType = ButtonCompon
           }
         : ComponentType extends ButtonComponentType.anchor
           ? {
+                ref?: Ref<HTMLAnchorElement>
                 component: ButtonComponentType.anchor
                 linkProps?: never
                 buttonProps?: never
@@ -74,6 +76,7 @@ export type ButtonProps<ComponentType extends ButtonComponentType = ButtonCompon
                 onClick?: AnchorHTMLAttributes<HTMLAnchorElement>['onClick']
             }
           : {
+                ref?: Ref<HTMLButtonElement>
                 /**
                  * Component to be rendered from the available options
                  *

src/Shared/Components/Popover/usePopover.hook.ts

@@ -130,6 +130,7 @@ export const usePopover = ({
             onKeyDown: handleTriggerKeyDown,
             'aria-haspopup': 'listbox',
             'aria-expanded': open,
+            className: 'flex',
             tabIndex: 0,
             bounds: triggerBounds ?? { left: 0, top: 0, height: 0, width: 0 },
         },