Merge pull request #999 from devtron-labs/fix/date-picker-focus

fix: date picker focus

Author: arunjaindev

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.22.3",
+    "version": "1.22.4",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -19,7 +19,7 @@ import { VisibleModal } from '../Modals/VisibleModal'
 import './Drawer.scss'
 import { DTFocusTrapType } from '@Shared/Components/DTFocusTrap'
 
-export interface DrawerProps extends Pick<DTFocusTrapType, 'initialFocus'> {
+export interface DrawerProps extends Pick<DTFocusTrapType, 'initialFocus' | 'avoidFocusTrap' > {
     position: 'left' | 'right' | 'bottom' | 'top'
     children?: any
     backdrop?: boolean
@@ -45,6 +45,7 @@ export const Drawer = ({
     onClose,
     disableTransition,
     initialFocus = undefined,
+    avoidFocusTrap = false,
 }: DrawerProps) => {
     const drawerRef = useRef(null)
     useEffect(() => {
@@ -69,6 +70,7 @@ export const Drawer = ({
             onEscape={onEscape}
             close={onClose}
             initialFocus={initialFocus}
+            avoidFocusTrap={avoidFocusTrap}
         >
             <aside
                 style={style}

src/Common/Drawer/Drawer.tsx

@@ -27,6 +27,7 @@ export class VisibleModal extends React.Component<{
     close?: (e?) => void
     onEscape?: (e?) => void
     initialFocus?: DTFocusTrapType['initialFocus']
+    avoidFocusTrap?: boolean
 }> {
     constructor(props) {
         super(props)
@@ -56,6 +57,7 @@ export class VisibleModal extends React.Component<{
                 onEscape={this.escFunction}
                 onClick={this.handleBodyClick}
                 initialFocus={this.props.initialFocus ?? undefined}
+                avoidFocusTrap={this.props.avoidFocusTrap}
             >
                 <div className={this.props.parentClassName}>
                     <div className={`visible-modal__body ${this.props.className || ''}`}>{this.props.children}</div>

src/Common/Modals/VisibleModal.tsx

@@ -33,6 +33,7 @@ const Backdrop = ({
     deactivateFocusOnEscape = true,
     initialFocus,
     returnFocusOnDeactivate,
+    avoidFocusTrap,
 }: BackdropProps) => {
     // STATES
     const [portalContainer, setPortalContainer] = useState<HTMLElement | null>(null)
@@ -92,6 +93,7 @@ const Backdrop = ({
             deactivateFocusOnEscape={deactivateFocusOnEscape}
             initialFocus={initialFocus ?? undefined}
             returnFocusOnDeactivate={returnFocusOnDeactivate}
+            avoidFocusTrap={avoidFocusTrap}
         >
             <motion.div
                 initial={{ opacity: 0 }}

src/Shared/Components/Backdrop/Backdrop.tsx

@@ -19,7 +19,10 @@ import { MouseEvent, ReactNode } from 'react'
 import { DTFocusTrapType } from '../DTFocusTrap'
 
 export interface BackdropProps
-    extends Pick<DTFocusTrapType, 'deactivateFocusOnEscape' | 'initialFocus' | 'onEscape' | 'returnFocusOnDeactivate'> {
+    extends Pick<
+        DTFocusTrapType,
+        'deactivateFocusOnEscape' | 'initialFocus' | 'onEscape' | 'returnFocusOnDeactivate' | 'avoidFocusTrap'
+    > {
     /**
      * The content to be rendered within the backdrop component.
      */

src/Shared/Components/Backdrop/types.ts

@@ -46,6 +46,7 @@ const ConfirmationModalBody = ({
     shouldCloseOnEscape = true,
     isLandscapeView = false,
     showConfetti = false,
+    avoidFocusTrap = false,
 }: ConfirmationModalBodyProps) => {
     const { registerShortcut, unregisterShortcut } = useRegisterShortcut()
 
@@ -92,6 +93,7 @@ const ConfirmationModalBody = ({
             deactivateFocusOnEscape={shouldCloseOnEscape}
             // Since when custom input is present, we auto focus on input, else focus on primary button
             initialFocus={confirmationConfig ? false : `#${PRIMARY_BUTTON_ID}`}
+            avoidFocusTrap={avoidFocusTrap}
         >
             <motion.div
                 className={`${isLandscapeView ? 'w-500' : 'w-400'} confirmation-modal border__secondary flexbox-col br-8 bg__primary dc__m-auto mt-40`}

src/Shared/Components/ConfirmationModal/ConfirmationModal.tsx

@@ -104,6 +104,7 @@ export type ConfirmationModalProps<isConfig extends boolean = false> = PropsWith
      * @default false
      */
     showConfetti?: boolean
+    avoidFocusTrap?: boolean
 }> &
     ButtonConfigAndVariantType<isConfig> &
     (isConfig extends false

src/Shared/Components/ConfirmationModal/types.ts

@@ -14,40 +14,22 @@
  * limitations under the License.
  */
 
-import { createContext, useCallback, useContext, useEffect, useMemo, useState } from 'react'
+import { useCallback, useEffect } from 'react'
 import FocusTrap from 'focus-trap-react'
 
-import { noop } from '@Common/Helper'
 import { ALLOW_ACTION_OUTSIDE_FOCUS_TRAP } from '@Shared/constants'
 import { preventBodyScroll } from '@Shared/Helpers'
 
 import { DTFocusTrapType } from './types'
 
-const FocusTrapControlContext = createContext<{
-    disableFocusTrap: () => void
-    resumeFocusTrap: () => void
-}>(null)
-
-export const useFocusTrapControl = () => {
-    const context = useContext(FocusTrapControlContext)
-    if (!context) {
-        return {
-            disableFocusTrap: noop,
-            resumeFocusTrap: noop,
-        }
-    }
-    return context
-}
-
 const DTFocusTrap = ({
     onEscape,
     deactivateFocusOnEscape = true,
     children,
     initialFocus = undefined,
     returnFocusOnDeactivate = true,
+    avoidFocusTrap = false,
 }: DTFocusTrapType) => {
-    const [isFocusEnabled, setIsFocusEnabled] = useState(true)
-
     const handleEscape = useCallback(
         (e?: KeyboardEvent | MouseEvent) => {
             onEscape(e)
@@ -64,40 +46,30 @@ const DTFocusTrap = ({
         }
     }, [])
 
-    const focusContextValue = useMemo(
-        () => ({
-            disableFocusTrap: () => setIsFocusEnabled(false),
-            resumeFocusTrap: () => setIsFocusEnabled(true),
-        }),
-        [],
-    )
-
     return (
-        <FocusTrapControlContext.Provider value={focusContextValue}>
-            <FocusTrap
-                active={isFocusEnabled}
-                focusTrapOptions={{
-                    escapeDeactivates: handleEscape,
-                    initialFocus,
-                    allowOutsideClick: (event) => {
-                        // Allow up to 3 parent levels to check for the allowed class
-                        let el = event.target as Element | null
-                        let depth = 0
-                        while (el && depth < 4) {
-                            if (el.classList && el.classList.contains(ALLOW_ACTION_OUTSIDE_FOCUS_TRAP)) {
-                                return true
-                            }
-                            el = el.parentElement
-                            depth += 1
+        <FocusTrap
+            active={!avoidFocusTrap}
+            focusTrapOptions={{
+                escapeDeactivates: handleEscape,
+                initialFocus,
+                allowOutsideClick: (event) => {
+                    // Allow up to 3 parent levels to check for the allowed class
+                    let el = event.target as Element | null
+                    let depth = 0
+                    while (el && depth < 4) {
+                        if (el.classList && el.classList.contains(ALLOW_ACTION_OUTSIDE_FOCUS_TRAP)) {
+                            return true
                         }
-                        return false
-                    },
-                    returnFocusOnDeactivate,
-                }}
-            >
-                {children}
-            </FocusTrap>
-        </FocusTrapControlContext.Provider>
+                        el = el.parentElement
+                        depth += 1
+                    }
+                    return false
+                },
+                returnFocusOnDeactivate,
+            }}
+        >
+            {children}
+        </FocusTrap>
     )
 }
 

src/Shared/Components/DTFocusTrap/DTFocusTrap.tsx

@@ -14,5 +14,5 @@
  * limitations under the License.
  */
 
-export { default as DTFocusTrap, useFocusTrapControl } from './DTFocusTrap'
+export { default as DTFocusTrap } from './DTFocusTrap'
 export type { DTFocusTrapType } from './types'