Merge pull request #930 from devtron-labs/feat/misc-ui-issues

feat: tippy added in all breadcrumb icon

Author: shivani170

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.20.6-pre-7",
+    "version": "1.20.6-pre-11",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -4,14 +4,19 @@ import { Link } from 'react-router-dom'
 import { BreadcrumbText, getBreadCrumbSeparator } from './BreadcrumbStore'
 import { NestedBreadCrumbProps } from './Types'
 
-export const NestedBreadCrumb = ({ redirectUrl, linkText, profileName }: NestedBreadCrumbProps) => {
+export const NestedBreadCrumb = ({
+    redirectUrl,
+    linkText,
+    profileName,
+    nestedBreadCrumbsText,
+}: NestedBreadCrumbProps) => {
     const breadcrumbLinkClass = 'active dc__devtron-breadcrumb__item fs-16 fw-4 lh-1-5 dc__ellipsis-right dc__mxw-155'
 
     const breadcrumbs = [
         { type: 'link', label: linkText, to: redirectUrl },
         ...(profileName
             ? [
-                  { type: 'link', label: 'Profiles', to: redirectUrl },
+                  ...(nestedBreadCrumbsText ? [{ type: 'link', label: nestedBreadCrumbsText, to: redirectUrl }] : []),
                   {
                       type: 'text',
                       label: profileName,

src/Common/BreadCrumb/NestedBreadCrumb.tsx

@@ -67,4 +67,9 @@ export interface NestedBreadCrumbProps {
      * If not given, would show "Create Profile"
      */
     profileName: string
+    /**
+     * @default Profiles
+     * It is the text of the nested breadcrumb
+     */
+    nestedBreadCrumbsText?: string
 }

src/Common/BreadCrumb/Types.ts

@@ -11,8 +11,8 @@ export const ApplicationManagementIcon = () => (
         linkProps={{
             to: URLS.APPLICATION_MANAGEMENT_APP,
         }}
-        ariaLabel="Redirect to Devtron Apps"
-        showAriaLabelInTippy={false}
+        ariaLabel="Application Management"
+        showAriaLabelInTippy
         icon={<Icon name="ic-grid-view" color={null} />}
     />
 )

src/Pages-Devtron-2.0/ApplicationManagement/Shared/ApplicationManagementIcon/ApplicationManagementIcon.tsx

@@ -11,8 +11,8 @@ export const InfrastructureManagementIcon = () => (
         linkProps={{
             to: URLS.INFRASTRUCTURE_MANAGEMENT_RESOURCE_BROWSER,
         }}
-        ariaLabel="Redirect to Infrastructure Management Overview"
-        showAriaLabelInTippy={false}
+        ariaLabel="Infrastructure Management"
+        showAriaLabelInTippy
         icon={<Icon name="ic-cloud" color={null} />}
     />
 )

src/Pages-Devtron-2.0/InfrastructureManagement/Shared/InfrastructureManagementIcon/InfrastructureManagementIcon.tsx

@@ -15,8 +15,8 @@ export const getAutomationEnablementBreadcrumbConfig = () => ({
                     to: URLS.AUTOMATION_AND_ENABLEMENT_JOB,
                 }}
                 icon={<Icon name="ic-bot" color={null} />}
-                ariaLabel="Redirect to Automation & Enablement Overview"
-                showAriaLabelInTippy={false}
+                ariaLabel="Automation & Enablement"
+                showAriaLabelInTippy
             />
         ),
         linked: true,

src/Pages-Devtron-2.0/InfrastructureManagement/utils.tsx

@@ -37,6 +37,7 @@ const Descriptor = ({
                         redirectUrl={URLS.APPLICATION_MANAGEMENT_CONFIGURATIONS_BUILD_INFRA_PROFILES}
                         linkText={BUILD_INFRA_TEXT.HEADING}
                         profileName={profileName}
+                        nestedBreadCrumbsText="Profiles"
                     />
                     <InfoIconTippy
                         infoText={tippyInfoText ?? BUILD_INFRA_TEXT.EDIT_DEFAULT_TOOLTIP}