Skip to content

Commit 292b8e9

Browse files
committed
chore: status key added in ScanRecommendationsDTO
1 parent d4a03f6 commit 292b8e9

5 files changed

Lines changed: 13 additions & 5 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.23.4-beta-3",
3+
"version": "1.23.4-beta-4",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Components/Security/SecurityDetailsCards/SecurityDetailsCards.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ const SecurityDetailsCards = ({ scanResult, Sidebar }: SecurityDetailsCardsProps
7171
if (!scanResult?.scanned) {
7272
return (
7373
<div className="flexbox-col dc__gap-16 mw-600 dc__mxw-1000">
74-
{renderHeader()}
7574
<ReportTabEmptyState
7675
title={EMPTY_STATE_STATUS.CI_DETAILS_IMAGE_NOT_SCANNED.TITLE}
7776
subtitle={EMPTY_STATE_STATUS.CI_DETAILS_IMAGE_NOT_SCANNED.SUBTITLE}
@@ -83,7 +82,6 @@ const SecurityDetailsCards = ({ scanResult, Sidebar }: SecurityDetailsCardsProps
8382
if (!threatCount) {
8483
return (
8584
<div className="flexbox-col dc__gap-16 mw-600 dc__mxw-1000">
86-
{renderHeader()}
8785
<div className="flexbox-col en-2 bw-1 br-8 dc__gap-16 cn-9 p-16">
8886
<GenericEmptyState
8987
SvgImage={NoVulnerability}

src/Shared/Components/Security/SecurityModal/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export { CATEGORY_LABELS, SEVERITIES_LABEL_COLOR_MAP } from './constants'
2424
export { default as SecurityModal } from './SecurityModal'
2525
export { getSecurityScan, getSecurityScanRecommendations } from './service'
2626
export type {
27+
DockerScanStatusTypes,
2728
GetResourceScanDetailsPayloadType,
2829
GetResourceScanDetailsResponseType,
2930
ScanRecommendationsDTO,

src/Shared/Components/Security/SecurityModal/types.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,14 @@ export type CodeSnippet = {
264264
after: CodeSnippetLine[]
265265
}
266266

267+
export enum DockerScanStatusTypes {
268+
PENDING = 0,
269+
RUNNING = 1,
270+
COMPLETED = 2,
271+
FAILED = 3,
272+
SKIPPED = 4,
273+
}
274+
267275
export interface ScanRecommendationsDTO {
268276
severity_summary: {
269277
error: number
@@ -289,6 +297,7 @@ export interface ScanRecommendationsDTO {
289297
dockerfileHash: string
290298
id: number
291299
pipelineId: number
300+
status: DockerScanStatusTypes
292301
}
293302

294303
export interface SidebarPropsType {

0 commit comments

Comments
 (0)