Skip to content

Commit 81eb115

Browse files
author
Amrit Kashyap Borah
committed
fix: send boundaryGap in FloatingVariableSuggestion widget
1 parent abae49e commit 81eb115

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

src/Shared/Components/FloatingVariablesSuggestions/FloatingVariablesSuggestions.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const FloatingVariablesSuggestions = ({
4444
hideObjectVariables = true,
4545
showValueOnHover = true,
4646
isTemplateView,
47+
boundaryGap,
4748
}: FloatingVariablesSuggestionsProps) => {
4849
const [isActive, setIsActive] = useState<boolean>(false)
4950

@@ -62,8 +63,6 @@ const FloatingVariablesSuggestions = ({
6263
setIsActive(false)
6364
}, [])
6465

65-
const boundaryGap = { x: 32, y: 90 }
66-
6766
return (
6867
<>
6968
<div className={`${isActive ? 'dc__visibility-hidden dc__disable-click' : ''} `}>

src/Shared/Components/FloatingVariablesSuggestions/constants.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
export const SUGGESTIONS_SIZE = {
18-
width: 356,
19-
height: 504,
20-
}
21-
2217
export const NO_DEFINED_DESCRIPTION = 'No Defined Description'
2318
export const NO_DEFINED_VALUE = 'No Defined Value'
2419
export const SUGGESTIONS_INFO_TITLE = 'What is scoped variable?'

src/Shared/Components/FloatingVariablesSuggestions/types.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
import { DraggableWrapperProps } from '@Common/DraggableWrapper'
1718
import { AppConfigProps } from '@Pages/index'
1819

1920
export interface ScopedVariableType {
@@ -25,7 +26,9 @@ export interface ScopedVariableType {
2526
isRedacted: boolean
2627
}
2728

28-
export interface FloatingVariablesSuggestionsProps extends Required<Pick<AppConfigProps, 'isTemplateView'>> {
29+
export interface FloatingVariablesSuggestionsProps
30+
extends Required<Pick<AppConfigProps, 'isTemplateView'>>,
31+
Pick<DraggableWrapperProps, 'boundaryGap'> {
2932
zIndex: number
3033
appId?: string
3134
envId?: string

0 commit comments

Comments
 (0)