Skip to content

Commit 88cdc5c

Browse files
committed
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-common-lib into refactor/app-details
2 parents 57dff89 + 87bc9b8 commit 88cdc5c

20 files changed

Lines changed: 98 additions & 75 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.22.3-beta-1",
3+
"version": "1.22.6",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 10 additions & 0 deletions
Loading
20.1 KB
Loading

src/Common/Drawer/Drawer.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { VisibleModal } from '../Modals/VisibleModal'
1919
import './Drawer.scss'
2020
import { DTFocusTrapType } from '@Shared/Components/DTFocusTrap'
2121

22-
export interface DrawerProps extends Pick<DTFocusTrapType, 'initialFocus'> {
22+
export interface DrawerProps extends Pick<DTFocusTrapType, 'initialFocus' | 'avoidFocusTrap' > {
2323
position: 'left' | 'right' | 'bottom' | 'top'
2424
children?: any
2525
backdrop?: boolean
@@ -45,6 +45,7 @@ export const Drawer = ({
4545
onClose,
4646
disableTransition,
4747
initialFocus = undefined,
48+
avoidFocusTrap = false,
4849
}: DrawerProps) => {
4950
const drawerRef = useRef(null)
5051
useEffect(() => {
@@ -69,6 +70,7 @@ export const Drawer = ({
6970
onEscape={onEscape}
7071
close={onClose}
7172
initialFocus={initialFocus}
73+
avoidFocusTrap={avoidFocusTrap}
7274
>
7375
<aside
7476
style={style}

src/Common/Modals/VisibleModal.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export class VisibleModal extends React.Component<{
2727
close?: (e?) => void
2828
onEscape?: (e?) => void
2929
initialFocus?: DTFocusTrapType['initialFocus']
30+
avoidFocusTrap?: boolean
3031
}> {
3132
constructor(props) {
3233
super(props)
@@ -56,6 +57,7 @@ export class VisibleModal extends React.Component<{
5657
onEscape={this.escFunction}
5758
onClick={this.handleBodyClick}
5859
initialFocus={this.props.initialFocus ?? undefined}
60+
avoidFocusTrap={this.props.avoidFocusTrap}
5961
>
6062
<div className={this.props.parentClassName}>
6163
<div className={`visible-modal__body ${this.props.className || ''}`}>{this.props.children}</div>

src/Shared/Components/Backdrop/Backdrop.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const Backdrop = ({
3333
deactivateFocusOnEscape = true,
3434
initialFocus,
3535
returnFocusOnDeactivate,
36+
avoidFocusTrap,
3637
}: BackdropProps) => {
3738
// STATES
3839
const [portalContainer, setPortalContainer] = useState<HTMLElement | null>(null)
@@ -92,6 +93,7 @@ const Backdrop = ({
9293
deactivateFocusOnEscape={deactivateFocusOnEscape}
9394
initialFocus={initialFocus ?? undefined}
9495
returnFocusOnDeactivate={returnFocusOnDeactivate}
96+
avoidFocusTrap={avoidFocusTrap}
9597
>
9698
<motion.div
9799
initial={{ opacity: 0 }}

src/Shared/Components/Backdrop/types.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ import { MouseEvent, ReactNode } from 'react'
1919
import { DTFocusTrapType } from '../DTFocusTrap'
2020

2121
export interface BackdropProps
22-
extends Pick<DTFocusTrapType, 'deactivateFocusOnEscape' | 'initialFocus' | 'onEscape' | 'returnFocusOnDeactivate'> {
22+
extends Pick<
23+
DTFocusTrapType,
24+
'deactivateFocusOnEscape' | 'initialFocus' | 'onEscape' | 'returnFocusOnDeactivate' | 'avoidFocusTrap'
25+
> {
2326
/**
2427
* The content to be rendered within the backdrop component.
2528
*/

src/Shared/Components/ConfirmationModal/ConfirmationModal.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ const ConfirmationModalBody = ({
4646
shouldCloseOnEscape = true,
4747
isLandscapeView = false,
4848
showConfetti = false,
49+
avoidFocusTrap = false,
4950
}: ConfirmationModalBodyProps) => {
5051
const { registerShortcut, unregisterShortcut } = useRegisterShortcut()
5152

@@ -92,6 +93,7 @@ const ConfirmationModalBody = ({
9293
deactivateFocusOnEscape={shouldCloseOnEscape}
9394
// Since when custom input is present, we auto focus on input, else focus on primary button
9495
initialFocus={confirmationConfig ? false : `#${PRIMARY_BUTTON_ID}`}
96+
avoidFocusTrap={avoidFocusTrap}
9597
>
9698
<motion.div
9799
className={`${isLandscapeView ? 'w-500' : 'w-400'} confirmation-modal border__secondary flexbox-col br-8 bg__primary dc__m-auto mt-40`}

0 commit comments

Comments
 (0)