Merge pull request #984 from devtron-labs/fix/table-bulk

fix: remove unused bulk selection identifiers for multi page selection

Author: arunjaindev

src/Shared/Components/Table/InternalTable.tsx

@@ -24,7 +24,7 @@ import { UseRegisterShortcutProvider } from '@Common/Hooks'
 
 import { NO_ROWS_OR_GET_ROWS_ERROR } from './constants'
 import TableContent from './TableContent'
-import { FiltersTypeEnum, InternalTableProps, PaginationEnum, RowsResultType } from './types'
+import { FiltersTypeEnum, InternalTableProps, RowsResultType } from './types'
 import { getFilteringPromise, searchAndSortRows } from './utils'
 
 const InternalTable = <
@@ -79,8 +79,6 @@ const InternalTable = <
 
     const wrapperDivRef = useRef<HTMLDivElement>(null)
 
-    const { setIdentifiers } = bulkSelectionReturnValue ?? {}
-
     const searchSortTimeoutRef = useRef<number>(-1)
 
     useEffect(() => {
@@ -182,26 +180,6 @@ const InternalTable = <
 
     const areFilteredRowsLoading = _areFilteredRowsLoading || filteredRowsError === NO_ROWS_OR_GET_ROWS_ERROR
 
-    const visibleRows = useMemo(() => {
-        const normalizedFilteredRows = filteredRows ?? []
-
-        const paginatedRows =
-            paginationVariant !== PaginationEnum.PAGINATED
-                ? normalizedFilteredRows
-                : normalizedFilteredRows.slice(offset, offset + pageSize)
-
-        return paginatedRows
-    }, [paginationVariant, offset, pageSize, filteredRows])
-
-    useEffect(() => {
-        setIdentifiers?.(
-            visibleRows.reduce((acc, row) => {
-                acc[row.id] = row
-                return acc
-            }, {}),
-        )
-    }, [visibleRows])
-
     const Wrapper = ViewWrapper ?? Fragment
 
     const renderContent = () => {