fix: review comments

Author: AbhishekA1509

src/Shared/Components/AppStatusModal/AppStatusBody.tsx

@@ -32,7 +32,7 @@ export const AppStatusBody = ({ appDetails, type, handleShowConfigDriftModal }:
     const customMessage =
         type === 'stack-manager'
             ? 'The installation will complete when status for all the below resources become HEALTHY.'
-            : APP_STATUS_CUSTOM_MESSAGES[appDetails.resourceTree?.status?.toUpperCase()]
+            : APP_STATUS_CUSTOM_MESSAGES[appStatus]
 
     const infoCardItems: (Omit<ComponentProps<typeof InfoCardItem>, 'isLast'> & { id: number })[] = [
         {

src/Shared/Components/AppStatusModal/AppStatusModal.component.tsx

@@ -49,11 +49,10 @@ const AppStatusModal = ({
 
     const handleExternalSync = async () => {
         try {
-            const response = await getAppDetailsWrapper()
-            setFetchedAppDetails(response)
-
             pollingTimeoutRef.current = setTimeout(
-                () => {
+                async () => {
+                    const response = await getAppDetailsWrapper()
+                    setFetchedAppDetails(response)
                     // eslint-disable-next-line @typescript-eslint/no-floating-promises
                     handleExternalSync()
                 },
@@ -77,13 +76,8 @@ const AppStatusModal = ({
             fetchedAppDetails &&
             !pollingTimeoutRef.current
         ) {
-            pollingTimeoutRef.current = setTimeout(
-                () => {
-                    // eslint-disable-next-line @typescript-eslint/no-floating-promises
-                    handleExternalSync()
-                },
-                Number(window._env_.DEVTRON_APP_DETAILS_POLLING_INTERVAL) || 30000,
-            )
+            // eslint-disable-next-line @typescript-eslint/no-floating-promises
+            handleExternalSync()
         }
 
         return () => {

src/Shared/Components/AppStatusModal/service.ts

@@ -30,7 +30,7 @@ export const getAppDetails = async (
             appType: AppType.DEVTRON_APP,
         }
     } catch (error) {
-        if (getIsRequestAborted(error)) {
+        if (!getIsRequestAborted(error)) {
             showError(error)
         }
         throw error

src/Shared/Components/AppStatusModal/utils.tsx

@@ -10,18 +10,19 @@ export const getAppStatusMessageFromAppDetails = (appDetails: AppDetails): strin
         return ''
     }
 
+    const { conditions } = appDetails.resourceTree
+
+    if (Array.isArray(conditions) && conditions.length > 0 && conditions[0].message) {
+        return conditions[0].message
+    }
+
     const nodes: AggregatedNodes = aggregateNodes(
         appDetails.resourceTree.nodes || [],
         appDetails.resourceTree.podMetadata || [],
     )
 
-    const { conditions } = appDetails.resourceTree
     const rollout = nodes?.nodes?.Rollout?.entries()?.next()?.value?.[1]
 
-    if (Array.isArray(conditions) && conditions.length > 0 && conditions[0].message) {
-        return conditions[0].message
-    }
-
     if (rollout?.health?.message) {
         return rollout.health.message
     }