feat: replace table in GenericAppListing#1004
Merged
Merged
Conversation
whoami-amrit
commented
Jan 14, 2026
whoami-amrit
commented
Contributor
- feat: add expandable rows support in table
- feat: uat changes
- fix: css selector
- chore: add a comment
- chore: notification icons
- feat: expose expand row to CellComponent
- fix: uat
- fix: better table states
- feat: expand/collapse using right/left arrow
There was a problem hiding this comment.
Pull request overview
This PR adds expandable row functionality to the Table component, allowing rows to be expanded/collapsed to show nested content. The changes also include keyboard shortcuts for expand/collapse actions and various UI enhancements to support this feature.
Changes:
- Added expandable row support with expand/collapse UI controls and keyboard shortcuts (Arrow Left/Right)
- Extended table types to support expanded rows, row start icons, and additional filter configuration
- Added notification-related icons (ic-ses, ic-slack, ic-smtp, ic-webhook-config)
Reviewed changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Components/Table/utils.ts | Added additionalProps parameter to filter function |
| src/Shared/Components/Table/useTableWithKeyboardShortcuts.ts | Registered ArrowLeft/ArrowRight shortcuts for collapse/expand actions |
| src/Shared/Components/Table/types.ts | Extended types to support expandable rows, row icons, and enhanced filtering |
| src/Shared/Components/Table/styles.scss | Added styles for expand buttons, tree lines, and row start icons |
| src/Shared/Components/Table/constants.ts | Added ACTION_GUTTER_SIZE constant for expand/collapse column width |
| src/Shared/Components/Table/TableContent.tsx | Implemented expandable row rendering logic and UI controls |
| src/Shared/Components/Table/InternalTable.tsx | Integrated new table props and filter handling |
| src/Shared/Components/Icon/Icon.tsx | Added notification service icons (SES, Slack, SMTP, webhook-config) |
| src/Shared/Components/CICDHistory/ConflictedResourcesTable.tsx | Updated filter prop from no-op function to null |
| src/Common/SortableTableHeaderCell/types.ts | Added infoTooltipText property |
| src/Common/SortableTableHeaderCell/SortableTableHeaderCell.tsx | Implemented info tooltip rendering in header cells |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AbhishekA1509
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.