fix: showPagination logic for BE handled rows#1009
Merged
Conversation
whoami-amrit
commented
Jan 27, 2026
whoami-amrit
commented
Contributor
- feat: add expandable rows support in table
- feat: uat changes
- fix: css selector
- chore: add a comment
- chore: notification icons
- feat: expose expand row to CellComponent
- fix: uat
- fix: better table states
- feat: expand/collapse using right/left arrow
- feat: if onRowCilck provided handle enter press internally
- fix: review 3Bcomments
- chore: update common-lib
- fix: showPagination calc in TableContent
whoami-amrit
requested review from
vikramdevtron and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the showPagination logic for backend-handled rows in the Table component. The change modifies the condition that determines when pagination controls should be displayed.
Changes:
- Updated the
showPaginationcalculation logic to properly handle backend pagination by checkingtotalRowswhenisBEPaginationis true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AbhishekA1509
previously approved these changes
Jan 28, 2026
AbhishekA1509
left a comment
AbhishekA1509
left a comment
Member
There was a problem hiding this comment.
Can move this: ((isBEPagination && totalRows) || filteredRows?.length) into a variable with type number
AbhishekA1509
previously approved these changes
Jan 28, 2026
vivek-devtron
previously approved these changes
Jan 29, 2026
whoami-amrit
dismissed stale reviews from vivek-devtron and AbhishekA1509
via
f5b6227
chore: update version to 1.23.0 in package.json and package-lock.json
feat: release candidate v0.45.0
feat: add new icons and update ActionMenu and HelpButton components for OSS Plus upgrade
chore: icon added for notification event
…mon-lib into feat/auto-assign-user-permission
…ission feat: add empty state key illustration to illustrationMap and claude instructions
…ault chore: bump version to 1.23.3 and remove ENABLE_RESTART_WORKLOAD flag
…ib into feat/sec-vulnerability-table
AbhishekA1509
approved these changes
Mar 10, 2026
vivek-devtron
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.