-
Notifications
You must be signed in to change notification settings - Fork 7
feat: upgrade to react 19 #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
188 commits
Select commit
Hold shift + click to select a range
09ef590
feat: notifications page ui new icons added
asika-gadgeon fe7f280
feat: recommendation ui added new icon
asika-gadgeon f8dc9ab
feat: notification ui added new icon
asika-gadgeon bebb618
feat: notifications page ui new icons
asika-gadgeon 24c5c3f
feat: Icons for Recommendation status
chith-git 12d5241
feat: Icon name change
chith-git 804bb0a
feat:new root for connecting athena apis
chith-git e93208e
feat: chatbot changes
asika-gadgeon 754404e
adding new icons
chith-git 3722b01
feat: chatbot makdown styles updated
asika-gadgeon d6dba96
Icons added
chith-git a610454
icons changing to IconsV2
chith-git 16646ea
Removing unwanted changes
chith-git e013add
Icons adding
chith-git 91a76e3
Adding medium icon
chith-git dc4ef22
Correct icon replaced
chith-git df3d18f
code formatting
chith-git 516f676
Removing service paths
chith-git 4961797
API changes added
chith-git 10443db
feat: Runbook implentation
chith-git 85943f0
Changing the path
chith-git ac708d7
duplicates icons removed
chith-git a66904e
feat: chatbot graphs
asika-gadgeon e23ba7a
audit-logs
asika-gadgeon 867f263
sample run book link added
chith-git a882d6c
version bump
chith-git 195f2a9
version bump
chith-git 1f4c37c
charts added axes configs
asika-gadgeon bfa8934
chart config version update
asika-gadgeon 2b2a5de
version bump
chith-git ad6dab7
Merge remote-tracking branch 'origin/kubecon-2025' into develop-kubeo…
chith-git bd2f185
Merge pull request #945 from devtron-labs/develop-kubeon-devtron
chith-git 0c4370c
version bump
chith-git 6c415b0
version bump
chith-git b11fedc
reverted changes in axes config
asika-gadgeon 39a74ab
version bump
asika-gadgeon 81d2be0
graph fix version update
asika-gadgeon 71be984
Merge remote-tracking branch 'origin/kubecon-2025' into develop-kubec…
asika-gadgeon 5f49f1b
merged changes in chart
asika-gadgeon 34effbd
Merge pull request #954 from devtron-labs/develop-kubecon-merge
chith-git 762ed02
version bump
chith-git d9fd69d
Changing sample doc url
chith-git a6798df
version bump
chith-git e0e86aa
Merge branch 'kubecon-2025' of https://github.com/devtron-labs/devtro…
AbhishekA1509 3ba5401
chore: bump version to 1.20.6-pre-45 in package.json and package-lock…
AbhishekA1509 9168352
feat: update version to 1.20.6-pre-46, add notifications icon, and in…
AbhishekA1509 733755e
Merge branch 'kubecon-2025' of https://github.com/devtron-labs/devtro…
AbhishekA1509 1264044
chore: remove unused SVG icons and clean up Chart component props
arunjaindev 29d315a
Merge remote-tracking branch 'origin/fix/ai-fixes' into chore/update-…
arunjaindev 89fdc67
chore: remove unused SVG icons for confirmation and failure states
arunjaindev a488946
chore: remove unused SVG icons from Icon component
arunjaindev cab41b9
feat: Add SVG icon and expose hook.
arunjaindev 801b8c3
Merge pull request #973 from devtron-labs/refactor/ai-chat-history
arunjaindev 6faffb6
Merge pull request #958 from devtron-labs/chore/update-icons
arunjaindev 34acf7c
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
AbhishekA1509 bdd9f4e
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
AbhishekA1509 fb38dd4
feat: Remove HIDE_AUDIT_LOGS option from customEnv interface
AbhishekA1509 2d58eb2
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
AbhishekA1509 550e76b
chore: update version from 1.22.0-pre-0 to 1.22.0-beta-1 in package.j…
AbhishekA1509 624d90a
feat: add featureAskDevtronExpert to context and types for enhanced A…
AbhishekA1509 9d10def
feat: add ATHENA route to Constants and remove unused __ATHENA_ROOT__…
AbhishekA1509 bd6afa6
feat: remove unused AI recommendations and notifications logic from P…
AbhishekA1509 021bf24
feat: conditionally set Content-Type header for non-multipart request…
AbhishekA1509 743c185
chore: update version from 1.22.0-beta-1 to 1.22.0-beta-2 in package.…
AbhishekA1509 868035a
feat: add AIAgentContextSourceType enum and update AIAgentContextType…
AbhishekA1509 ef3de57
chore: update version from 1.22.0-beta-2 to 1.22.0-beta-3 in package.…
AbhishekA1509 0fae4b9
chore: update version to 1.22.0-beta-4 in package.json and package-lo…
AbhishekA1509 54dd39d
feat: add expandable rows support in table
29e793f
feat: enhance AppStatusModal with AI debugging capabilities and updat…
AbhishekA1509 a0da25e
feat: update version to 1.22.0-beta-5 in package.json and package-loc…
AbhishekA1509 eb50376
feat: uat changes
dc11f3d
chore: Remove runbook icon, routes, and documentation links.
arunjaindev b0f8e89
chore: remove `ic-line.svg` and its corresponding references from the…
arunjaindev 06cbd1d
feat: update AppStatusBody to use debugError instead of additionalMes…
AbhishekA1509 f7413b3
fix: css selector
471deb0
Merge pull request #998 from devtron-labs/chore/remove-runbooks-recos
AbhishekA1509 df03df5
chore: add a comment
deb23c6
feat: enhance debugAgentContext handling in AppStatusBody for improve…
AbhishekA1509 b530ec4
chore: notification icons
shivani170 e3119eb
feat: expose expand row to CellComponent
1108d26
Merge pull request #995 from devtron-labs/feat/ai-context
AbhishekA1509 a52064b
fix: uat
098312a
Merge branch 'feat/app-list-table' of github.com:devtron-labs/devtron…
1b2280a
Merge pull request #997 from devtron-labs/feat/debug-ai
AbhishekA1509 513b20d
feat: refine debugAgentContext prompt for clarity in AppStatusBody
AbhishekA1509 351a35a
fix: better table states
460b941
feat: expand/collapse using right/left arrow
78407ce
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-com…
AbhishekA1509 8636f74
chore: update version to 1.22.5-beta-0 in package.json and package-lo…
AbhishekA1509 7ab7b14
feat: if onRowCilck provided handle enter press internally
3912efe
chore: update version to 1.22.5-beta-1 in package.json and package-lo…
AbhishekA1509 d837685
Merge pull request #1005 from devtron-labs/fix/ai-qa
AbhishekA1509 574d219
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-com…
AbhishekA1509 e39ee9e
chore: update version to 1.22.6-beta-0 in package.json and package-lo…
AbhishekA1509 b4d2bcb
fix: review 3Bcomments
4743e56
Merge pull request #1004 from devtron-labs/feat/generic-app-list
whoami-amrit ae57aab
chore: update common-lib
9a9a948
Merge branch 'feat/app-list-table' of github.com:devtron-labs/devtron…
19aed84
Merge pull request #996 from devtron-labs/feat/app-list-table
whoami-amrit 1dc3999
chore: update version to 1.22.6-beta-1 in package.json and package-lo…
AbhishekA1509 c4b966f
chore: icon added for notification event
shivani170 e11656c
chore: image approve svg fix
shivani170 314135a
chore: bell icon added
shivani170 1e72bc0
feat: add new icons for medium megaphone, thumb down fill, and thumb …
AbhishekA1509 71de0d5
fix: showPagination calc in TableContent
725d754
fix: loading state logic
e747beb
feat: add app name validation function and regex pattern
AbhishekA1509 b0f32e0
chore: update version to 1.22.6-beta-4 in package.json and package-lo…
AbhishekA1509 c230c05
chore: icon update for configuration
shivani170 5ed7898
chore: version bump
shivani170 59a005e
chore: version bump
shivani170 f5b6227
fix: style of empty div
982763f
chore: update version to 1.22.6-beta-5 in package.json and package-lo…
AbhishekA1509 4a41fbd
chore: update version to 1.22.6-beta-6 in package.json and package-lo…
AbhishekA1509 6190ae8
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-com…
AbhishekA1509 f0fc643
Merge branch 'fix/ai-fixes' of https://github.com/devtron-labs/devtro…
AbhishekA1509 aee954f
Merge branch 'fix/ai-fixes' of https://github.com/devtron-labs/devtro…
AbhishekA1509 e76c0e1
Merge pull request #1008 from devtron-labs/feat/ai-feedback
AbhishekA1509 1cb9812
Merge branch 'fix/ai-fixes' of https://github.com/devtron-labs/devtro…
AbhishekA1509 7c819c2
bump version to 1.22.8-beta-3 in package.json and package-lock.json
AbhishekA1509 60177eb
bump version to 1.22.8-beta-4 in package.json and package-lock.json
AbhishekA1509 9946e19
Merge branch 'fix/ai-fixes' of https://github.com/devtron-labs/devtro…
AbhishekA1509 aff2fc3
refactor: update useMutation options type for consistency
AbhishekA1509 22a27ac
Merge branch 'fix/ai-fixes' of https://github.com/devtron-labs/devtro…
AbhishekA1509 b07ed17
Merge pull request #1012 from devtron-labs/feat/ai-actions-and-feedback
AbhishekA1509 9981a8a
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
AbhishekA1509 70084b3
Merge pull request #957 from devtron-labs/fix/ai-fixes
AbhishekA1509 ac59ead
Add Empty State Key illustration to illustrationMap
AbhishekA1509 79befa0
Bump version to 1.22.8-beta-11 in package.json and package-lock.json
AbhishekA1509 3cb156d
feat: enhance component type definitions and improve ref handling
arunjaindev a599756
feat: update version to 1.22.8-beta-12
arunjaindev 7cfd477
chore: update version to 1.23.0 in package.json and package-lock.json
AbhishekA1509 5b05644
Merge pull request #1017 from devtron-labs/chore/rc-version-bump
AbhishekA1509 4f4b49c
Merge pull request #1018 from devtron-labs/release-candidate-v0.45.0
AbhishekA1509 212ba31
feat: remove unnecessary semicolons in multiple components
arunjaindev 39efab1
Add new icons and update ActionMenu and HelpButton components for OSS…
AbhishekA1509 9d13fc9
fix: typo in HelpMenuItems enum and update HelpButton case reference
AbhishekA1509 7c46752
Merge branch 'main' into feat/notification-events
shivani170 c5e2a82
Merge pull request #1019 from devtron-labs/feat/notify-oss-plus
AbhishekA1509 1d27ec3
chore: version bump
shivani170 8ae9c97
Merge pull request #1007 from devtron-labs/feat/notification-events
shivani170 bff0416
Merge branch 'main' of https://github.com/devtron-labs/devtron-fe-com…
AbhishekA1509 5a13ef0
Merge pull request #1014 from devtron-labs/feat/auto-assign-user-perm…
AbhishekA1509 0b58c21
Merge branch 'feat/react-18' of https://github.com/devtron-labs/devtr…
arunjaindev 107160d
refactor: remove avoidFocusTrap prop from multiple components and del…
arunjaindev 891bc2f
chore: bump version to 1.23.3 and remove ENABLE_RESTART_WORKLOAD flag
arunjaindev e4b25a6
Merge pull request #1020 from devtron-labs/feat/restart-workloads-def…
arunjaindev 5726353
chore: update version to 1.22.8-beta-15 in package.json
arunjaindev 08b5914
Merge branch 'develop' of github.com:devtron-labs/devtron-fe-common-l…
58d46c1
chore: bump version
1641306
chore: bump version
3ab20be
feat: add useRef for nodeRef in SortableTableHeaderCell component
arunjaindev 9e8d271
fix: empty state
a4ad1bd
fix: bulk and start icon clash
a8b4f11
Merge pull request #1009 from devtron-labs/feat/sec-vulnerability-table
whoami-amrit e58ee79
Merge branch 'develop' of github.com:devtron-labs/devtron-fe-common-l…
05f6ee7
chore: bump version
00a8b68
Merge pull request #1022 from devtron-labs/feat/tag-list
whoami-amrit 9b0a35e
fix: prevent null date handling in handleSingleDateSelect of DateTime…
AbhishekA1509 19917f4
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
arunjaindev 7f58c54
chore: version bump
arunjaindev 86c3e07
Merge branch 'feat/react-19' of https://github.com/devtron-labs/devtr…
AbhishekA1509 38297fc
chore: bump version to 1.23.3-beta-2 in package.json and package-lock…
AbhishekA1509 1f240c3
Merge pull request #1023 from devtron-labs/feat/markdown-stream
AbhishekA1509 1bb2693
chore: bump version to 1.23.3-beta-3 in package.json and package-lock…
AbhishekA1509 0d0d9cf
feat: add openPopover function to usePopover hook and integrate with …
AbhishekA1509 710a71f
chore: update version from 1.23.3-alpha-2 to 1.23.3-beta-4 in package…
AbhishekA1509 7dd8219
chore: update vite plugins
arunjaindev aa23c9c
chore: update vite dependencies
arunjaindev 728e797
chore: update version to 1.23.3-beta-5 and fix popover variant naming…
AbhishekA1509 0daf8f0
chore: update version from 1.23.3-beta-5 to 1.23.3-pre-0 in package.j…
AbhishekA1509 9215bec
Merge pull request #1025 from devtron-labs/feat/app-filter-by-label
AbhishekA1509 ffa4ce2
chore: update vite to v8
arunjaindev b7363b4
chore: update import statement for react-toastify to use syntax
arunjaindev bd60f9f
chore: version bump
arunjaindev 3f0df86
chore: version bump
arunjaindev 415f9df
chore: version bump
arunjaindev f1d5f57
chore: version bump
arunjaindev a8cfab0
chore: update version to 1.23.4 in package.json and package-lock.json…
AbhishekA1509 175245b
chore: update version to 1.23.4-pre-0 in package.json and package-loc…
AbhishekA1509 d6322e3
Merge pull request #1028 from devtron-labs/chore/main-develop-sync
AbhishekA1509 885fe22
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-…
arunjaindev c13cadb
chore: upgrade ansi up lib
arunjaindev c28ccf7
chore: add user preferences migration logic
arunjaindev 4fade82
fix: update useQuery to include missing dependencies in InternalTable
arunjaindev 6898c23
fix: implement user preferences migration logic to ensure compatibili…
arunjaindev 0d6e641
Merge pull request #1030 from devtron-labs/fix/user-preferences-types
arunjaindev 873cbe0
Merge pull request #1026 from devtron-labs/chore/update-vite
arunjaindev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| # CLAUDE.md | ||
|
|
||
| This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository. | ||
|
|
||
| ## Overview | ||
|
|
||
| `@devtron-labs/devtron-fe-common-lib` is a React component and utility library for the Devtron platform. It is built with Vite and published to npm as an ES module. | ||
|
|
||
| ## Commands | ||
|
|
||
| ```bash | ||
| # Type-check + lint (strict, max-warnings=0) | ||
| npm run lint | ||
|
|
||
| # Auto-fix lint issues | ||
| npm run lint-fix | ||
|
|
||
| # Build with source maps (development/local linking) | ||
| npm run build | ||
|
|
||
| # Watch mode rebuild with source maps | ||
| npm run build-watch | ||
|
|
||
| # Build without source maps (CI/CD, publishing) | ||
| npm run build-lib | ||
|
|
||
| # Vite dev server | ||
| npm run dev | ||
|
|
||
| # Generate icon/illustration components from SVGs | ||
| npm run generate-icon | ||
| npm run generate-illustration | ||
| ``` | ||
|
|
||
| There are no tests currently (`npm test` is a no-op). | ||
|
|
||
| ## Architecture | ||
|
|
||
| ### Entry & Exports | ||
|
|
||
| `src/index.ts` re-exports everything from four top-level modules: | ||
|
|
||
| - **`src/Common/`** — Legacy utilities, hooks, and components (BreadCrumb, SearchBar, Checkbox, etc.) | ||
| - **`src/Shared/`** — Primary reusable code: 100+ UI components, hooks, providers, services, API utilities, types, helpers, constants, validations | ||
| - **`src/Pages/`** — Full-page components (Applications, BulkEdit, GlobalConfigurations, ResourceBrowser) | ||
| - **`src/Pages-Devtron-2.0/`** — New Devtron 2.0 features (ApplicationManagement, Navigation, SecurityCenter, etc.) | ||
|
|
||
| ### Component Structure Convention | ||
|
|
||
| Components follow a consistent directory layout: | ||
|
|
||
| ``` | ||
| ComponentName/ | ||
| ├── ComponentName.component.tsx # Main component (forwardRef + React.memo typical) | ||
| ├── types.ts # TypeScript interfaces/types | ||
| ├── constants.ts # Component-level constants | ||
| ├── utils.ts # Helper functions | ||
| ├── component.scss # Scoped SCSS styles | ||
| └── index.ts # Barrel export | ||
| ``` | ||
|
|
||
| ### Key Architectural Patterns | ||
|
|
||
| **State management**: React Context API only — `MainContextProvider`, `ThemeProvider`, `UserEmailProvider`. No Redux/Zustand. | ||
|
|
||
| **API layer**: TanStack Query (React Query v4) via `CoreAPI` class. API queuing handled via `APIQueuing`. Custom query hooks live in `Shared/API/reactQueryHooks.ts`. | ||
|
arunjaindev marked this conversation as resolved.
|
||
|
|
||
| **Styling**: SCSS with BEM naming. CSS is injected into JS chunks via `vite-plugin-lib-inject-css`. No CSS modules. | ||
|
|
||
| **SVG icons**: Imported as React components via `vite-plugin-svgr`. Two icon generations: `src/Assets/Icon/` and `src/Assets/IconV2/`. Do **not** use `IconBase` or `IllustrationBase` directly — use the `Icon` and `Illustration` wrapper components. | ||
|
|
||
| **Toasts**: Do **not** import from `react-toastify` directly — use `ToastManager` from the library. | ||
|
|
||
| **Forms**: Dynamic forms use `@rjsf` (React JSON Schema Form). Custom form hooks in `Shared/Hooks/`. | ||
|
|
||
| **Router**: React Router v6 (`useBlocker` etc.). The `usePrompt` hook handles navigation blocking. | ||
|
|
||
| ### TypeScript & Path Aliases | ||
|
|
||
| `tsconfig.json` configures path aliases used throughout the codebase: | ||
|
|
||
| | Alias | Maps to | | ||
| | -------------------- | ------------------------- | | ||
| | `@Icons/*` | `src/Assets/Icon/*` | | ||
| | `@IconsV2/*` | `src/Assets/IconV2/*` | | ||
| | `@Common/*` | `src/Common/*` | | ||
| | `@Shared/*` | `src/Shared/*` | | ||
| | `@Pages/*` | `src/Pages/*` | | ||
| | `@PagesDevtron2.0/*` | `src/Pages-Devtron-2.0/*` | | ||
|
|
||
| Strict mode is **off** in tsconfig. Target is ES2020, module is ESNext. | ||
|
|
||
| ### Build Output | ||
|
|
||
| Vite splits the bundle into named chunks: `@vendor`, `@code-editor`, `@framer-motion`, `@moment`, `@react-select`, `@react-virtualized-sticky-tree`, `@common-rjsf`, `@src-assets-*`. Output is ES modules only, landing in `dist/`. Type declarations are generated via `vite-plugin-dts` at `dist/index.d.ts`. | ||
|
|
||
| ## Code Style | ||
|
|
||
| - **Prettier**: No semicolons, single quotes, 120-char print width, 4-space tabs, trailing commas everywhere. | ||
| - **ESLint**: Airbnb + TypeScript + Prettier. Import order enforced by `eslint-plugin-simple-import-sort`. | ||
| - **Pre-commit**: `lint-staged` runs ESLint on staged `.{js,jsx,ts,tsx}` files via Husky. | ||
| - JSX only in `.tsx` files (not `.jsx`). | ||
| - `no-console` is a warning (not error). | ||
|
|
||
| ## CI/CD | ||
|
|
||
| - **PRs**: Node version from `.nvmrc`, `npm ci`, `npm run lint`, `npm run build-lib`. | ||
| - **Releases**: Triggered by GitHub release creation, runs `npm test` + `npm run build-lib` + `npm publish --access public` using `NPM_TOKEN` secret. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.