Skip to content

feat: app filter by label#1025

Merged
AbhishekA1509 merged 4 commits into
developfrom
feat/app-filter-by-label
Mar 24, 2026
Merged

feat: app filter by label#1025
AbhishekA1509 merged 4 commits into
developfrom
feat/app-filter-by-label

Conversation

@AbhishekA1509

Copy link
Copy Markdown
Member

Description

This pull request introduces significant enhancements to the GroupedFilterSelectPicker component, enabling support for rendering filter pickers inside a popover and improving flexibility in configuration. The changes include updates to the popover hook and types, as well as refactoring the component logic to handle both standard and popover variants.

GroupedFilterSelectPicker enhancements:

  • Refactored GroupedFilterSelectPicker to support both standard and popover variants, allowing filter pickers to be rendered inside a Popover when configured. The component now dynamically chooses the rendering strategy based on the variant specified in filterSelectPickerPropsMap. [1] [2] [3] [4]
  • Updated the GroupedFilterSelectPickerProps type to accept a map of variants, including a new popOver variant with configuration for popover position, alignment, and width, as well as a custom component function for rendering inside the popover.

Popover hook improvements:

  • Added an openPopover function to the usePopover hook and its return type, allowing programmatic control of the popover's open state. [1] [2] [3]
  • Improved event cleanup in the usePopover hook by using optional chaining when removing event listeners, preventing potential errors if the reference is null.

Other updates:

  • Updated the package version from 1.23.3-alpha-2 to 1.23.3-beta-4 in package.json.
  • Made minor improvements to type imports and fallback logic in other components. [1] [2] [3]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copilot AI review requested due to automatic review settings March 19, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the GroupedFilterSelectPicker to support rendering filter pickers inside a Popover (via a new map “variant”), and updates the popover hook/types to allow programmatic opening.

Changes:

  • Add a popOver (popover) variant to filterSelectPickerPropsMap and refactor GroupedFilterSelectPicker to render either a FilterSelectPicker or a Popover-hosted custom component.
  • Extend usePopover with an openPopover() API and improve event listener cleanup.
  • Minor refactors and version bump to 1.23.3-beta-4.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Shared/Components/Table/InternalTable.tsx Simplifies handleClearFilters fallback selection.
src/Shared/Components/SelectPicker/type.ts Adds variant-aware types for GroupedFilterSelectPicker config, including popover config/component.
src/Shared/Components/SelectPicker/GroupedFilterSelectPicker.tsx Refactors rendering to support both standard and popover variants using usePopover + Popover.
src/Shared/Components/Popover/usePopover.hook.ts Adds openPopover() and makes wheel listener cleanup null-safe.
src/Shared/Components/Popover/types.ts Extends return type with openPopover().
package.json Bumps package version to beta.
package-lock.json Updates lockfile version metadata for the new package version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/Shared/Components/SelectPicker/GroupedFilterSelectPicker.tsx Outdated
Comment thread src/Shared/Components/SelectPicker/type.ts Outdated
Comment thread src/Shared/Components/SelectPicker/type.ts Outdated
vivek-devtron
vivek-devtron previously approved these changes Mar 20, 2026
vivek-devtron
vivek-devtron previously approved these changes Mar 23, 2026
@AbhishekA1509 AbhishekA1509 merged commit 9215bec into develop Mar 24, 2026
6 checks passed
@AbhishekA1509 AbhishekA1509 deleted the feat/app-filter-by-label branch March 24, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants