feat: app filter by label#1025
Merged
Merged
Conversation
…GroupedFilterSelectPicker
….json and package-lock.json
There was a problem hiding this comment.
Pull request overview
This PR extends the GroupedFilterSelectPicker to support rendering filter pickers inside a Popover (via a new map “variant”), and updates the popover hook/types to allow programmatic opening.
Changes:
- Add a
popOver(popover) variant tofilterSelectPickerPropsMapand refactorGroupedFilterSelectPickerto render either aFilterSelectPickeror aPopover-hosted custom component. - Extend
usePopoverwith anopenPopover()API and improve event listener cleanup. - Minor refactors and version bump to
1.23.3-beta-4.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Components/Table/InternalTable.tsx | Simplifies handleClearFilters fallback selection. |
| src/Shared/Components/SelectPicker/type.ts | Adds variant-aware types for GroupedFilterSelectPicker config, including popover config/component. |
| src/Shared/Components/SelectPicker/GroupedFilterSelectPicker.tsx | Refactors rendering to support both standard and popover variants using usePopover + Popover. |
| src/Shared/Components/Popover/usePopover.hook.ts | Adds openPopover() and makes wheel listener cleanup null-safe. |
| src/Shared/Components/Popover/types.ts | Extends return type with openPopover(). |
| package.json | Bumps package version to beta. |
| package-lock.json | Updates lockfile version metadata for the new package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
vivek-devtron
previously approved these changes
Mar 20, 2026
… in SelectPicker components
vivek-devtron
previously approved these changes
Mar 23, 2026
…son and package-lock.json
vivek-devtron
approved these changes
Mar 24, 2026
abhibhaw
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant enhancements to the
GroupedFilterSelectPickercomponent, enabling support for rendering filter pickers inside a popover and improving flexibility in configuration. The changes include updates to the popover hook and types, as well as refactoring the component logic to handle both standard and popover variants.GroupedFilterSelectPicker enhancements:
GroupedFilterSelectPickerto support both standard and popover variants, allowing filter pickers to be rendered inside aPopoverwhen configured. The component now dynamically chooses the rendering strategy based on the variant specified infilterSelectPickerPropsMap. [1] [2] [3] [4]GroupedFilterSelectPickerPropstype to accept a map of variants, including a newpopOvervariant with configuration for popover position, alignment, and width, as well as a custom component function for rendering inside the popover.Popover hook improvements:
openPopoverfunction to theusePopoverhook and its return type, allowing programmatic control of the popover's open state. [1] [2] [3]usePopoverhook by using optional chaining when removing event listeners, preventing potential errors if the reference is null.Other updates:
1.23.3-alpha-2to1.23.3-beta-4inpackage.json.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist