chore: update timeout references to support number type#1035
Merged
Conversation
chore: bump version to 1.23.4 and add pagination select menu styles
feat: add support for init containers in Pod nodes and update iNode interface
…mon-lib into chore/main-sync
vivek-devtron
approved these changes
Apr 9, 2026
arunjaindev
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several updates across the codebase, focusing on improving type safety for timeout references, updating Node.js version requirements, and enhancing the resource tree structure to support init containers in Pods. The most significant changes are summarized below:
Type safety improvements for timeout references:
useRef, local variables, and interface props) to use a union type ofReturnType<typeof setTimeout> | numberfor better type safety and compatibility across environments. This affects files such asClipboardButton.tsx,UseRegisterShortcutProvider.tsx,BulkOperations.component.tsx,readOnlyTooltip.ts, andTable/types.ts. [1] [2] [3] [4] [5] [6] [7] [8]Resource tree enhancements:
IndexStore.tsxto add support for displaying both init containers and regular containers as child nodes under Pod nodes, and marked init containers with anisInitContainerflag for display purposes. [1] [2]Dependency and environment updates:
.nvmrcfromv22tov24.14.1to ensure compatibility with latest features and security updates.package.jsonfrom1.23.4-pre-2to1.23.5-pre-1.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist