Skip to content

fix: user export list #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunjaindev merged 2 commits into from
Jun 2, 2026
Merged

fix: user export list #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64bd346
fix: refactor abort controller initialization and handle download log…
AbhishekA1509 Jun 1, 2026
0259616
fix: update version to 4.0.6 in package.json and package-lock.json
AbhishekA1509 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@devtron-labs/devtron-fe-common-lib",
"version": "4.0.5",
"version": "4.0.6",
"description": "Supporting common component library",
"type": "module",
"main": "dist/index.js",
Expand Down
25 changes: 16 additions & 9 deletions src/Shared/Components/ExportToCsv/ExportToCsv.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ const ExportToCsv = <HeaderItemType extends string>({
downloadRequestId,
}: ExportToCsvProps<HeaderItemType>) => {
const csvRef = useRef(null)
const abortControllerRef = useRef<AbortController>(new AbortController())
const abortControllerRef = useRef<AbortController>(null)

const [dataToExport, setDataToExport] = useState<Awaited<ReturnType<typeof apiPromise>>>([])
const [confirmationModalType, setConfirmationModalType] = useState<'default' | 'custom' | null>(null)
const [isLoading, setIsLoading] = useState(false)
const [dataFetchError, setDataFetchError] = useState<ServerErrors>(null)
const [pendingDownload, setPendingDownload] = useState(false)

const handleInitiateDownload = async () => {
if (disabled) {
Expand All @@ -41,8 +42,7 @@ const ExportToCsv = <HeaderItemType extends string>({
setDataFetchError(null)
const data = await apiPromise({ signal: abortControllerRef.current.signal })
setDataToExport(data)

csvRef.current?.link?.click()
setPendingDownload(true)
} catch (error) {
if (!getIsRequestAborted(error)) {
showError(error)
Expand All @@ -64,12 +64,12 @@ const ExportToCsv = <HeaderItemType extends string>({
}
}

useEffect(
() => () => {
abortControllerRef.current.abort()
},
[],
)
useEffect(() => {
abortControllerRef.current = new AbortController()
return () => {
abortControllerRef.current?.abort()
}
}, [])

useEffect(() => {
if (!isNullOrUndefined(downloadRequestId)) {
Expand All @@ -78,6 +78,13 @@ const ExportToCsv = <HeaderItemType extends string>({
}
}, [downloadRequestId])

useEffect(() => {
if (pendingDownload) {
csvRef.current?.link?.click()
setPendingDownload(false)
}
}, [pendingDownload])

const handleCancelRequest = () => {
abortControllerRef.current.abort()
abortControllerRef.current = new AbortController()
Expand Down
Loading