feat: app status modal#707
Merged
Merged
Conversation
…Memo for improved performance
…r DeploymentStatusDetailRow for cleaner code
…tor components for improved structure
…d error handling and polling mechanism
…ng accessibility with memoized IDs
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
…ssibility, remove deprecated AppStatusDetailsChart, and enhance AppStatusBody with custom messages
…tatusModal to utilize dynamic titles
…yling, including grid adjustments and word break handling
…to require envId, and enhance styling in AppStatusModal and DeploymentStatusDetailRow components
AbhishekA1509
commented
Apr 23, 2025
… in AppStatusModal
…and layout, including adjustments to ErrorBar and AppStatusContent styling
…useMemo hooks and enhancing layout with improved styling
RohitRaj011
previously requested changes
Apr 25, 2025
…improved performance
…handling - Updated Drawer export to simplify import paths. - Refactored AppStatusModal to accept title segments as an array, improving title rendering. - Removed unused utility function for title generation. - Cleaned up imports in AppStatusModal for better clarity. - Introduced a new constant for app health dropdown list in CICDHistory.
feat: release tenant mapping
…ntent rendering - Moved GenericEmptyState and GenericFilterEmptyState exports to a new index file for better structure. - Updated AppStatusModal to utilize GenericEmptyState for improved content handling when app details are unavailable.
vivek-devtron
previously approved these changes
Apr 29, 2025
…s filter in StatusFilterButtonComponent - Updated AppStatusModal to ensure proper cleanup of resources on unmount. - Enhanced StatusFilterButtonComponent to handle cases where the selected tab is not found in the status filters.
…erButtonComponent logic
- Introduced new SCSS styles for the StatusFilterButton, enhancing the segmented control appearance. - Updated StatusFilterButtonComponent to apply new styles and ensure proper handling of selected tab values.
…lterButtonComponent key handling - Removed unnecessary dependency from SegmentedControl's useEffect for improved performance. - Added a unique key to the SegmentedControl in StatusFilterButtonComponent to ensure proper re-rendering based on inline filters.
…common-lib into feat/app-status-modal
…common-lib into feat/app-status-modal
…common-lib into feat/app-status-modal
vivek-devtron
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to bring new App Status modal which caters to the cases of devtron-apps, external-apps, release and stack manager through a single component.
Type of change
How Has This Been Tested?
QA
Checklist