-
Notifications
You must be signed in to change notification settings - Fork 7
chore: doc link component added #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
135edce
chore: doc link component added
shivani170 82a037e
chore: added doc link in tippy customoze
shivani170 5c186f8
chore: Documentation constant added in doc link component
shivani170 ad5a2aa
chore: modification in the naming of the Doclink
shivani170 4c8f1eb
chore: modification in the naming of the Doclink
shivani170 f5855bc
chore: size props added in links
shivani170 2556b62
chore: Replaced all Doc link anchor with docLink Component
shivani170 726d320
chore: type added for documentation link
shivani170 7def66d
fix: Update DocLink component to handle isEnterprise prop
shivani170 29e6812
Merge branch 'develop' into feat/doc-utm-source
shivani170 ef7d8c0
feat: add FEATURE_REDFISH_NODE_ENABLE to customEnv interface
AbhishekA1509 1eddf38
chore: code refactoring
shivani170 58b7d85
feat: enhance SegmentedBarChart with hideLegend prop and update types
AbhishekA1509 9b45b39
fix: update getBarChartEntities return type to NonNullable<Entity[]>
AbhishekA1509 2f4ef2f
chore: isExternalLink support for ci external plugins
shivani170 ad5e1c3
chore: text fix for documentation in page header
shivani170 7fca4fc
chore: isEnterprise tpe moved to page header
shivani170 5ff3361
feat: add thermometer icon and update icon map
AbhishekA1509 f6900c4
chore: css fixes
shivani170 ab2aead
feat: add terminal icon and update icon map
AbhishekA1509 659e83f
fix: correct z-index for search panel in code editor
RohitRaj011 406fe06
chore: version bump
RohitRaj011 9baa102
Merge pull request #738 from devtron-labs/fix/code-editor-panel-z-index
RohitRaj011 e567368
fix: update NodeDetailTabsInfoType to use renderComponent instead of …
AbhishekA1509 7412648
fix: update version to 1.13.0-redfish-preview-beta-1 in package.json …
AbhishekA1509 2ffd730
fix: update version to 1.13.0-pre-8 in package.json and package-lock.…
AbhishekA1509 3e250dc
Merge branch 'release-candidate-v0.36.0' of https://github.com/devtro…
AbhishekA1509 ce2759d
Merge pull request #741 from devtron-labs/feat/redfish-node-ui-rc
AbhishekA1509 d3af342
Merge branch 'develop' into feat/doc-utm-source
shivani170 ceb4929
fix: set default value for NodeDrainOptions
cca05f2
chore(version): bump to 1.14.0
RohitRaj011 9865d73
Merge pull request #743 from devtron-labs/fix/bulk-drain
whoami-amrit 8fcd059
Merge branch 'release-candidate-v0.36.0' into rc-merge/v0.36.0
RohitRaj011 e39ac3d
Merge pull request #744 from devtron-labs/rc-merge/v0.36.0
whoami-amrit 4335197
Merge pull request #745 from devtron-labs/release-candidate-v0.36.0
RohitRaj011 efc2597
chore: moved doc link to shared
shivani170 b8f0677
chore: type strict
shivani170 bb3d3d3
Merge branch 'main' into feat/doc-utm-source
shivani170 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { DOCUMENTATION_HOME_PAGE, DOCUMENTATION_VERSION } from '..' | ||
| import { DocLinkProps } from './types' | ||
|
|
||
| export const appendUtmToUrl = (docLink: string) => `${docLink}?utm_source=product` | ||
|
|
||
| export const getDocumentationUrl = (docLink: string) => | ||
|
shivani170 marked this conversation as resolved.
Outdated
|
||
| `${DOCUMENTATION_HOME_PAGE}${DOCUMENTATION_VERSION}/${appendUtmToUrl(docLink)}` | ||
|
|
||
| export const DocLink = ({ docLink, docLinkText = 'Learn more', dataTestId, className = 'dc__link' }: DocLinkProps) => ( | ||
| <a | ||
|
shivani170 marked this conversation as resolved.
Outdated
|
||
| href={getDocumentationUrl(docLink)} | ||
| target="_blank" | ||
| rel="noreferrer noopener" | ||
| data-testid={dataTestId || ''} | ||
| className={className} | ||
| > | ||
| {docLinkText} | ||
| </a> | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { DocLink, getDocumentationUrl } from './DocLink' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export interface DocLinkProps { | ||
| docLink: string | ||
| dataTestId: string | ||
| docLinkText?: string | ||
| className?: string | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.