feat: add smoothScrollToTop and expose onSearchAction event on CodeEditor#755
Merged
Conversation
…common-lib into feat/virtualize-logs
…common-lib into fix/app-details-manifest-layout
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
AbhishekA1509
changed the title
…rch functionality feat(Helpers): update smoothScrollToTop easing function to use CUBIC_BEZIER_CURVE constant feat(constants): define CUBIC_BEZIER_CURVE constant for consistent animation easing
…common-lib into fix/app-details-manifest-layout
RohitRaj011
suggested changes
May 29, 2025
RohitRaj011
previously approved these changes
May 29, 2025
vivek-devtron
previously approved these changes
May 29, 2025
AbhishekA1509
dismissed stale reviews from vivek-devtron and RohitRaj011
via
769438b
vivek-devtron
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: add smoothScrollToTop and expose onSearchAction event on CodeEditor
Type of change
How Has This Been Tested?
Dev tested
Checklist