feat: Notification screen Implementation-Added Icons#919
Conversation
chith-git
requested review from
vikramdevtron and
vivek-devtron
as code owners
AbhishekA1509
left a comment
AbhishekA1509
left a comment
There was a problem hiding this comment.
Pls delete these files:
src/Shared/Components/SelectPicker/GroupedFilterSelectPicker.example.tsx
src/Shared/Components/SelectPicker/GroupedFilterSelectPicker-Usage-Guide.md
| @@ -0,0 +1,3 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" fill="none" viewBox="0 0 14 14"> | |||
There was a problem hiding this comment.
We can use ic-coins instead with sending color B500 as prop for Icon
| @@ -0,0 +1,6 @@ | |||
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
We can use ic-circle-loader, pls check across the PR for other icons as well if there are any counterpart present like ic-speedometer, etc
chith-git
force-pushed
the
feat/notification
branch
from
542599f to
c5d799c
Compare
chith-git
force-pushed
the
feat/notification
branch
from
2fb58ea to
2eba490
Compare
| @@ -0,0 +1,3 @@ | |||
| <svg width="12" height="13" viewBox="0 0 12 13" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
Pls delete this is ic-bug
| @@ -0,0 +1,3 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" fill="none" viewBox="0 0 14 14"> | |||
| <path fill="#B23412" d="M3.063 7h-.876a.875.875 0 0 0-.874.875v3.5c0 .483.391.875.875.875h.874a.875.875 0 0 0 .876-.875v-3.5A.875.875 0 0 0 3.062 7Zm4.375-2.625h-.875a.875.875 0 0 0-.875.875v6.125c0 .483.391.875.875.875h.875a.875.875 0 0 0 .875-.875V5.25a.875.875 0 0 0-.876-.875Zm4.375-2.625h-.876a.875.875 0 0 0-.874.875v8.75c0 .483.391.875.874.875h.876a.875.875 0 0 0 .874-.875v-8.75a.875.875 0 0 0-.874-.875Z"/> | |||
There was a problem hiding this comment.
This is ic-priority-medium-fill itself just send color prop
| @@ -0,0 +1,4 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" fill="none" viewBox="0 0 14 14"> | |||
| <path fill="#106240" d="M3.063 7h-.876a.875.875 0 0 0-.874.875v3.5c0 .483.391.875.875.875h.874a.875.875 0 0 0 .876-.875v-3.5A.875.875 0 0 0 3.062 7Z"/> | |||
There was a problem hiding this comment.
This is ic-priority-medium-fill itself just send color prop
| @@ -0,0 +1,5 @@ | |||
| <svg width="32" height="32" viewBox="0 0 32 32" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <rect width="32" height="32" rx="4" fill="#1E1F28"/> | |||
There was a problem hiding this comment.
This is ic-edit leverage that with centred in div
| @@ -0,0 +1,3 @@ | |||
| <svg width="2" height="14" viewBox="0 0 2 14" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
This should be achieved with css instead have looked into design, say in case the text is multiline the height should increase subsequently
There was a problem hiding this comment.
For example:
In Design these are connected to avatar there is no gap
3 participants
Added icons for Recommendation List and Recommendation Details screens