feat: add utils required for devtron saas#983
Merged
Merged
Conversation
…ck.json; add instanceData to DevtronLicenseDTO type
- Imported ImgInstallFreemiumSaas and ImgInstallViaAwsMarketplace SVGs. - Updated illustrationMap to include new illustrations for 'img-install-freemium-saas' and 'img-install-via-aws-marketplace'.
….json; add img-page-not-found.svg illustration and update DevtronLicenseCard to handle SaaS instance
….json; add isSaasInstance to DevtronLicenseCardProps and update utils to derive its value from instanceData
….json; add LICENSE_KEY_QUERY_PARAM constant
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds utilities and types required to support Devtron SaaS functionality. The changes introduce a new isSaasInstance flag that determines whether the license is for a SaaS instance, along with new instance data types and conditional rendering logic for the license card component.
Key Changes:
- Added
instanceDatafield to theDevtronLicenseDTOtype for central dashboard instances - Introduced
isSaasInstanceflag derived from the presence ofinstanceData.devtronUrl - Added conditional rendering in the license card to hide certain information for SaaS instances
- Added new illustration assets for SaaS and AWS marketplace installation flows
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Shared/types.ts |
Added instanceData with URL and password fields to conditional license DTO type |
src/Shared/constants.tsx |
Added LICENSE_KEY_QUERY_PARAM constant for query parameter handling |
src/Shared/Components/License/utils.tsx |
Added isSaasInstance flag detection based on instanceData.devtronUrl presence |
src/Shared/Components/License/types.ts |
Added isSaasInstance boolean property to license card props |
src/Shared/Components/License/DevtronLicenseCard.tsx |
Refactored time display logic and added conditional rendering for SaaS instances |
src/Shared/Components/Illustration/Illustration.tsx |
Added three new illustration imports for SaaS and marketplace flows |
src/Assets/Illustration/img-page-not-found.svg |
New SVG asset for 404 page illustration |
src/Assets/Illustration/img-install-via-aws-marketplace.svg |
New SVG asset for AWS marketplace installation flow |
src/Assets/Illustration/img-install-freemium-saas.svg |
New SVG asset for freemium SaaS installation flow |
package.json |
Version bumped to 1.21.0-beta-11 |
package-lock.json |
Lock file updated to match package.json version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…k.json; add activateLicense export in License component
…k.json; update instanceData handling in License component
…lustration - Updated package.json and package-lock.json to version 1.21.1-beta-1 - Added new SVG illustration for celebration to the assets - Updated Illustration.tsx to include the new celebration illustration in the illustration map
… isSaasInstance and add it to DevtronLicenseDTO
vivek-devtron
previously approved these changes
Dec 17, 2025
… include isFreeForever logic and enhance license status handling
…tronLicenseBaseDTO to string
… enhance freemium message logic
vivek-devtron
approved these changes
Dec 19, 2025
shivani170
approved these changes
Dec 19, 2025
arunjaindev
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: add utils required for devtron saas
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist