Skip to content

fix: remove unused bulk selection identifiers for multi page selection #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunjaindev merged 1 commit into from
Dec 16, 2025
Merged

fix: remove unused bulk selection identifiers for multi page selection #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions src/Shared/Components/Table/InternalTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { UseRegisterShortcutProvider } from '@Common/Hooks'

import { NO_ROWS_OR_GET_ROWS_ERROR } from './constants'
import TableContent from './TableContent'
import { FiltersTypeEnum, InternalTableProps, PaginationEnum, RowsResultType } from './types'
import { FiltersTypeEnum, InternalTableProps, RowsResultType } from './types'
import { getFilteringPromise, searchAndSortRows } from './utils'

const InternalTable = <
Expand Down Expand Up @@ -79,8 +79,6 @@ const InternalTable = <

const wrapperDivRef = useRef<HTMLDivElement>(null)

const { setIdentifiers } = bulkSelectionReturnValue ?? {}

const searchSortTimeoutRef = useRef<number>(-1)

useEffect(() => {
Expand Down Expand Up @@ -182,26 +180,6 @@ const InternalTable = <

const areFilteredRowsLoading = _areFilteredRowsLoading || filteredRowsError === NO_ROWS_OR_GET_ROWS_ERROR

const visibleRows = useMemo(() => {
const normalizedFilteredRows = filteredRows ?? []

const paginatedRows =
paginationVariant !== PaginationEnum.PAGINATED
? normalizedFilteredRows
: normalizedFilteredRows.slice(offset, offset + pageSize)

return paginatedRows
}, [paginationVariant, offset, pageSize, filteredRows])

useEffect(() => {
setIdentifiers?.(
visibleRows.reduce((acc, row) => {
acc[row.id] = row
return acc
}, {}),
)
}, [visibleRows])

const Wrapper = ViewWrapper ?? Fragment

const renderContent = () => {
Expand Down