rename isSuccess to isFailed

Author: ayu-devtron

ci-runner/executor/stage/cdStages.go

@@ -234,7 +234,7 @@ func (impl *CdStage) runCDStages(ciCdRequest *helper.CiCdTriggerEvent) (*helper.
 }
 
 func sendCDFailureEvent(ciRequest *helper.CommonWorkflowRequest, err *helper.CdStageError) {
-	event := adaptor.NewCdCompleteEvent(ciRequest, false).
+	event := adaptor.NewCdCompleteEvent(ciRequest, true).
 		WithIsArtifactUploaded(err.IsArtifactUploaded())
 	e := helper.SendCDEvent(ciRequest, event)
 	if e != nil {
@@ -244,7 +244,7 @@ func sendCDFailureEvent(ciRequest *helper.CommonWorkflowRequest, err *helper.CdS
 
 func sendCDSuccessEvent(commonWorkflowRequest *helper.CommonWorkflowRequest, allPluginArtifacts *helper.PluginArtifacts, artifactUploaded bool) {
 	log.Println(util.DEVTRON, " event")
-	event := adaptor.NewCdCompleteEvent(commonWorkflowRequest, true).
+	event := adaptor.NewCdCompleteEvent(commonWorkflowRequest, false).
 		WithPluginArtifacts(allPluginArtifacts).
 		WithIsArtifactUploaded(artifactUploaded)
 	err := helper.SendCDEvent(commonWorkflowRequest, event)

ci-runner/helper/EventHelper.go

@@ -449,7 +449,7 @@ type CdStageCompleteEvent struct {
 	PluginArtifactStage           string              `json:"pluginArtifactStage"`
 	PluginArtifacts               *PluginArtifacts    `json:"pluginArtifacts"`
 	IsArtifactUploaded            bool                `json:"isArtifactUploaded"`
-	IsSuccess                     bool                `json:"isSuccess"`
+	IsFailed                      bool                `json:"isFailed"` //new flag as isFailed for backward compatibility
 }
 
 func (event *CdStageCompleteEvent) WithPluginArtifacts(pluginArtifacts *PluginArtifacts) *CdStageCompleteEvent {

ci-runner/helper/adaptor/CiStageAdaptor.go

@@ -23,7 +23,7 @@ func NewCiCompleteEvent(ciRequest *helper.CommonWorkflowRequest) *helper.CiCompl
 	return event
 }
 
-func NewCdCompleteEvent(cdRequest *helper.CommonWorkflowRequest, isSuccess bool) *helper.CdStageCompleteEvent {
+func NewCdCompleteEvent(cdRequest *helper.CommonWorkflowRequest, isFailed bool) *helper.CdStageCompleteEvent {
 	event := &helper.CdStageCompleteEvent{
 		CiProjectDetails:              cdRequest.CiProjectDetails,
 		CdPipelineId:                  cdRequest.CdPipelineId,
@@ -33,7 +33,7 @@ func NewCdCompleteEvent(cdRequest *helper.CommonWorkflowRequest, isSuccess bool)
 		TriggeredBy:                   cdRequest.TriggeredBy,
 		PluginRegistryArtifactDetails: cdRequest.RegistryDestinationImageMap,
 		PluginArtifactStage:           cdRequest.PluginArtifactStage,
-		IsSuccess:                     isSuccess,
+		IsFailed:                      isFailed,
 	}
 	return event
 }