feat: mount file type variable in ci-runner through cm

Author: Ash-exp

ci-runner/executor/StageExecutor.go

@@ -294,7 +294,7 @@ func (impl *StageExecutorImpl) RunCiCdStep(stepType helper.StepType, ciCdRequest
 		stepIndexFileMountMap := make(map[int]map[string]*fileContentDto)
 		for _, inVar := range step.InputVars {
 			if inVar.Format == commonBean.FormatTypeFile {
-				fileContent := newFileContentDto(inVar.FileContent, inVar.Value)
+				fileContent := newFileContentDto(inVar.FileReferencePath, inVar.Value)
 				if fileMap, ok := stepIndexFileMountMap[inVar.VariableStepIndexInPlugin]; ok {
 					fileMap[inVar.Name] = fileContent
 					stepIndexFileMountMap[inVar.VariableStepIndexInPlugin] = fileMap
@@ -320,8 +320,8 @@ func (impl *StageExecutorImpl) RunCiCdStep(stepType helper.StepType, ciCdRequest
 			if fileMap, ok := stepIndexFileMountMap[step.Index]; ok {
 				for _, inVar := range step.InputVars {
 					if fileContent, ok := fileMap[inVar.Name]; ok {
-						inVar.Value = fileContent.filePath
-						inVar.FileContent = fileContent.content
+						inVar.Value = fileContent.mountPath
+						inVar.FileReferencePath = fileContent.referencePath
 					}
 				}
 			}

ci-runner/executor/scriptExecutor.go

@@ -178,14 +178,14 @@ type executionConf struct {
 }
 
 type fileContentDto struct {
-	content  string
-	filePath string
+	referencePath string
+	mountPath     string
 }
 
-func newFileContentDto(content, filePath string) *fileContentDto {
+func newFileContentDto(fileReferencePath, fileMountPath string) *fileContentDto {
 	return &fileContentDto{
-		content:  content,
-		filePath: filePath,
+		referencePath: fileReferencePath,
+		mountPath:     fileMountPath,
 	}
 }
 

ci-runner/vendor/github.com/devtron-labs/common-lib/workflow/bean.go

@@ -24,6 +24,7 @@ import (
 )
 
 const (
+	ConfigMapKind                = "ConfigMap"
 	SecretKind                   = "Secret"
 	ServiceKind                  = "Service"
 	ServiceAccountKind           = "ServiceAccount"
@@ -300,8 +301,8 @@ type PodMetadata struct {
 	EphemeralContainers []*EphemeralContainerData `json:"ephemeralContainers"`
 }
 
-// use value field as generic type
 // InfoItem contains arbitrary, human readable information about an application
+// use value field as generic type
 type InfoItem struct {
 	// Name is a human readable title for this piece of information.
 	Name string `json:"name,omitempty"`

common-lib/utils/k8s/commonBean/bean.go

@@ -1,7 +1,6 @@
 package workflow
 
 import (
-	"encoding/base64"
 	"encoding/json"
 	"fmt"
 	"os"
@@ -168,8 +167,8 @@ type VariableObject struct {
 	ReferenceVariableName      string       `json:"referenceVariableName"`
 	ReferenceVariableStepIndex int          `json:"referenceVariableStepIndex"`
 	VariableStepIndexInPlugin  int          `json:"variableStepIndexInPlugin"`
-	FileContent                string       `json:"fileContent"` // FileContent is the base64 encoded content of the file
-	TypedValue                 interface{}  `json:"-"`           // TypedValue is the formatted value of the variable after type conversion
+	FileReferencePath          string       `json:"fileReferencePath"` // FileContent is the base64 encoded content of the file
+	TypedValue                 interface{}  `json:"-"`                 // TypedValue is the formatted value of the variable after type conversion
 }
 
 // TypeCheck converts the VariableObject.Value to the VariableObject.Format type
@@ -188,19 +187,25 @@ func (v *VariableObject) TypeCheck() error {
 	return nil
 }
 
-// SetFileContent decodes the base64 encoded file content and writes it to the file at filePath
+// SetFileContent sets the content of the file referenced by the VariableObject.FileReferencePath field.
 func (v *VariableObject) SetFileContent(filePath string) error {
 	if v.Format != FormatTypeFile {
 		return nil
 	}
+	if len(v.FileReferencePath) == 0 {
+		// for plugins we may receive the filePath as "",
+		// even thought VariableObject.Value is there;
+		// for this case don't mount the file.
+		return nil
+	}
 	file, fileErr := os.OpenFile(filePath, os.O_RDWR|os.O_CREATE|os.O_TRUNC, os.ModePerm)
 	if fileErr != nil {
 		return fileErr
 	}
 	defer file.Close()
-	fileBytes, fileErr := base64.StdEncoding.DecodeString(v.FileContent)
-	if fileErr != nil {
-		return fileErr
+	fileBytes, err := os.ReadFile(v.FileReferencePath)
+	if err != nil {
+		return err
 	}
 	_, wErr := file.Write(fileBytes)
 	if wErr != nil {