fix: added support for http and scp based git host#228
Merged
27 commits merged intoApr 25, 2025
Merged
Conversation
fix: postgresql skip unique constraints error and handle network connection error
fix: panic handling issues
sync: Main sync develop
Shivam-nagar23
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
nishant-d
suggested changes
Apr 15, 2025
| return checkoutPath, httpsMatched, sshMatched, nil | ||
| return checkoutPath, nil | ||
| } | ||
| // this regex is used to generic ssh providers like gogs where format is <user>@<host>:<org>/<repo>.git |
Contributor
There was a problem hiding this comment.
this format is followed by other proder like bit-bucket and azure also.
how they were working earlier ?
Member
Author
There was a problem hiding this comment.
Yes it would have worked only for repo starting with git specifically like git@bitbucket.org:bitbucketpipelines/example-scp-deploy.git , it was handled for git@ not for generic user@
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.