fix: Docker login condition for devtron job#254
Merged
Conversation
Ash-exp
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
github-actions
Bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
nishant-d
previously approved these changes
May 6, 2025
Ash-exp
force-pushed
the
fix-docker-login-devtron-job
branch
from
788171c to
ac36170
Compare
Ash-exp
force-pushed
the
fix-docker-login-devtron-job
branch
from
ac36170 to
173a944
Compare
nishant-d
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2190