fix: optimised handle progressing flows#269
Merged
Merged
Conversation
Shivam-nagar23
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
github-actions
Bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
prkhrkat
reviewed
May 16, 2025
prkhrkat
reviewed
May 16, 2025
This change introduces a new service name constant, "IMAGE_SCANNER," to the `ServiceName` enum. It ensures consistent referencing of the ImageScanner service throughout the codebase.
Introduced an asynchronous runnable to handle concurrent execution of tasks in the ImageScanner service. Integrated async initialization and execution throughout the service, ensuring proper error recovery and logging for panics in goroutines. Updated the common-lib dependency to include new async utilities.
nishant-d
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2147
Have done optmisation on query level where all data was fetched and made the flow non-blocking for server.
Further Scan can be executed parallelly