fix: enhanced query param validation for commit metadata for pipeline material

SATYAsasini · SATYAsasini · commit 0113b69df985 · 2025-08-22T04:16:14.000+05:30
diff --git a/api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go b/api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go
@@ -1664,9 +1664,11 @@ func (handler *PipelineConfigRestHandlerImpl) GetCommitMetadataForPipelineMateri
 		return
 	}
 	vars := mux.Vars(r)
-	ciPipelineMaterialId, err := strconv.Atoi(vars["ciPipelineMaterialId"])
+	ciPipelineMaterialIdString := vars["ciPipelineMaterialId"]
+	ciPipelineMaterialId, err := strconv.Atoi(ciPipelineMaterialIdString)
 	if err != nil {
-		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
+		handler.Logger.Errorw("failed to extract ciPipelineMaterialId from param must be integer", "error", err, "ciPipelineMaterialId", ciPipelineMaterialIdString)
+		common.HandleParameterError(w, r, "ciPipelineMaterialId", ciPipelineMaterialIdString)
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1664,9 +1664,11 @@ func (handler *PipelineConfigRestHandlerImpl) GetCommitMetadataForPipelineMateri`
`1664`	`1664`	`return`
`1665`	`1665`	`}`
`1666`	`1666`	`vars := mux.Vars(r)`
`1667`		`- ciPipelineMaterialId, err := strconv.Atoi(vars["ciPipelineMaterialId"])`
	`1667`	`+ ciPipelineMaterialIdString := vars["ciPipelineMaterialId"]`
	`1668`	`+ ciPipelineMaterialId, err := strconv.Atoi(ciPipelineMaterialIdString)`
`1668`	`1669`	`if err != nil {`
`1669`		`- common.WriteJsonResp(w, err, nil, http.StatusBadRequest)`
	`1670`	`+ handler.Logger.Errorw("failed to extract ciPipelineMaterialId from param must be integer", "error", err, "ciPipelineMaterialId", ciPipelineMaterialIdString)`
	`1671`	`+ common.HandleParameterError(w, r, "ciPipelineMaterialId", ciPipelineMaterialIdString)`
`1670`	`1672`	`return`
`1671`	`1673`	`}`
`1672`	`1674`