review comments

Author: prkhrkat

client/telemetry/TelemetryEventClient.go

@@ -317,18 +317,6 @@ func (impl *TelemetryEventClientImpl) SendSummaryEvent(eventType string) error {
 	payload.PhysicalClusterCount, payload.IsolatedClusterCount = impl.getClusterCounts()
 	payload.ActiveUsersLast30Days = impl.getActiveUsersLast30Days()
 
-	// Set FULL-mode only metrics to 0 for EA mode
-	payload.DevtronAppCount = 0
-	payload.JobCount = 0
-	payload.JobPipelineCount = 0
-	payload.JobPipelineTriggeredLast24h = 0
-	payload.JobPipelineSucceededLast24h = 0
-	payload.UserCreatedPluginCount = 0
-	payload.PolicyCount = 0
-	payload.AppliedPolicyRowCount = 0
-	payload.GitOpsPipelineCount = 0
-	payload.NoGitOpsPipelineCount = 0
-
 	payload.ClusterProvider, err = impl.GetCloudProvider()
 	if err != nil {
 		impl.logger.Errorw("error while getting cluster provider", "error", err)

client/telemetry/bean.go

@@ -76,20 +76,10 @@ type TelemetryEventEA struct {
 	ExternalHelmAppClusterCount        map[int32]int      `json:"ExternalHelmAppClusterCount,omitempty"`
 	ClusterProvider                    string             `json:"clusterProvider,omitempty"`
 	// New telemetry fields
-	HelmAppCount                int `json:"helmAppCount,omitempty"`
-	DevtronAppCount             int `json:"devtronAppCount,omitempty"`
-	JobCount                    int `json:"jobCount,omitempty"`
-	JobPipelineCount            int `json:"jobPipelineCount,omitempty"`
-	JobPipelineTriggeredLast24h int `json:"jobPipelineTriggeredLast24h,omitempty"`
-	JobPipelineSucceededLast24h int `json:"jobPipelineSucceededLast24h,omitempty"`
-	UserCreatedPluginCount      int `json:"userCreatedPluginCount,omitempty"`
-	PolicyCount                 int `json:"policyCount,omitempty"`
-	AppliedPolicyRowCount       int `json:"appliedPolicyRowCount,omitempty"`
-	PhysicalClusterCount        int `json:"physicalClusterCount,omitempty"`
-	IsolatedClusterCount        int `json:"isolatedClusterCount,omitempty"`
-	ActiveUsersLast30Days       int `json:"activeUsersLast30Days,omitempty"`
-	GitOpsPipelineCount         int `json:"gitOpsPipelineCount,omitempty"`
-	NoGitOpsPipelineCount       int `json:"noGitOpsPipelineCount,omitempty"`
+	HelmAppCount          int `json:"helmAppCount,omitempty"`
+	PhysicalClusterCount  int `json:"physicalClusterCount,omitempty"`
+	IsolatedClusterCount  int `json:"isolatedClusterCount,omitempty"`
+	ActiveUsersLast30Days int `json:"activeUsersLast30Days,omitempty"`
 }
 
 const AppsCount int = 50

client/telemetry/telemetryQueriesExtended.go

@@ -82,7 +82,7 @@ func (impl *TelemetryEventClientImplExtended) getPolicyCount() int {
 	globalPolicies, err := impl.cvePolicyRepository.GetGlobalPolicies()
 	if err != nil {
 		impl.logger.Errorw("error getting global CVE policies", "err", err)
-		return 0
+		return -1
 	}
 	return len(globalPolicies)
 }
@@ -128,10 +128,10 @@ func (impl *TelemetryEventClientImplExtended) helmPipelineCount() int {
 
 // getJobPipelineCount returns 0 for now as implementation is not yet available
 func (impl *TelemetryEventClientImplExtended) getJobPipelineCount() int {
-	return 0
+	return -1
 }
 
 // getAppliedPolicyRowCount returns 0 for now as implementation is not yet available
 func (impl *TelemetryEventClientImplExtended) getAppliedPolicyRowCount() int {
-	return 0
+	return -1
 }