Skip to content

feat: add env-driven timeout for buildx builder pod readiness#6944

Merged
Ash-exp merged 4 commits intomainfrom
feat/buildx-builder-pod-wait-timeout
Mar 31, 2026
Merged

feat: add env-driven timeout for buildx builder pod readiness#6944
Ash-exp merged 4 commits intomainfrom
feat/buildx-builder-pod-wait-timeout

Conversation

@Ash-exp
Copy link
Copy Markdown
Contributor

@Ash-exp Ash-exp commented Mar 30, 2026

Description

Fixes #6191

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • Reformatted env_gen.json from minified JSON to properly indented and readable JSON structure.
  • No modifications to the actual environment variable definitions or values.
  • Enhanced file readability for better maintenance and review.

Ash-exp added 4 commits March 28, 2026 08:22
Introduces BUILDX_BUILDER_POD_WAIT_DURATION_SECS (default 120s) to
control how long ci-runner waits for buildx k8s driver builder pods
to reach Running state — both on initial startup and after spot
interruption recovery. Previously the post-interruption wait was
hardcoded to 2 minutes with no control on initial startup.

Changes:
- BuildxGlobalFlags: add BuildxBuilderPodWaitDurationSecs field
- WorkflowRequest: add buildxBuilderPodWaitDurationSecs JSON field
- HandlerService_ent: propagate new field in updateWorkflowRequestWithBuildxFlags
- env_gen.json: document new CI_BUILDX env var
- Tests: BuildxGlobalFlags defaults, propagation, JSON compat
@github-actions
Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions
Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud
Copy link
Copy Markdown

@Ash-exp Ash-exp merged commit ab29f75 into main Mar 31, 2026
12 of 14 checks passed
@Ash-exp Ash-exp deleted the feat/buildx-builder-pod-wait-timeout branch March 31, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Make buildx Flags Configurable

3 participants