Skip to content

feat: Added support to override container name #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawan-mehta-dt merged 4 commits into from
Dec 5, 2025
Merged

feat: Added support to override container name #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41ba9dc
Added support to override container name
pawan-mehta-dt Dec 4, 2025
d37ad90
Fixed container name override for secondary workload
pawan-mehta-dt Dec 4, 2025
b3a409f
Fixed container name override for statefulset
pawan-mehta-dt Dec 4, 2025
b9112e8
Fixed container name override for deployment hpa secondary workload
pawan-mehta-dt Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down Expand Up @@ -825,7 +825,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down
8 changes: 4 additions & 4 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -52,7 +52,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down Expand Up @@ -126,7 +126,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -135,7 +135,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down
6 changes: 6 additions & 0 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ pauseForSecondsBeforeSwitchActive: 30
waitForSecondsBeforeScalingDown: 30
autoPromotionSeconds: 30

# Optional override for the main container name. If provided, this name will be used
# for the primary container instead of the default chart-derived name.
containerName: ""

Spec:
Affinity:
Key: ""
Expand Down Expand Up @@ -704,6 +708,8 @@ customPodLabels: {}

secondaryWorkload:
enabled: false
# Optional override for secondary workload's main container name
containerName: ""
Spec:
Affinity:
Key: ""
Expand Down
2 changes: 1 addition & 1 deletion scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -52,7 +52,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down
4 changes: 4 additions & 0 deletions scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ pauseForSecondsBeforeSwitchActive: 30
waitForSecondsBeforeScalingDown: 30
autoPromotionSeconds: 30

# Optional override for the main container name. If provided, this name will be used
# for the primary container instead of the default chart-derived name.
containerName: ""

Spec:
Affinity:
Key:
Expand Down
4 changes: 2 additions & 2 deletions scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -53,7 +53,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down
2 changes: 1 addition & 1 deletion scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down
4 changes: 4 additions & 0 deletions scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ pauseForSecondsBeforeSwitchActive: 30
waitForSecondsBeforeScalingDown: 30
autoPromotionSeconds: 30

# Optional override for the main container name. If provided, this name will be used
# for the primary container instead of the default chart-derived name.
containerName: ""

Spec:
Affinity:
Key:
Expand Down