Skip to content

misc: update UserDeploymentRequestWithAdditionalFields struct to include tableName for PostgreSQL compatibility#6896

Merged
Ash-exp merged 2 commits into
mainfrom
fix/async-helm-deploy
Dec 16, 2025
Merged

misc: update UserDeploymentRequestWithAdditionalFields struct to include tableName for PostgreSQL compatibility#6896
Ash-exp merged 2 commits into
mainfrom
fix/async-helm-deploy

Conversation

@Ash-exp

@Ash-exp Ash-exp commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • This pull request adds a tableName field to the UserDeploymentRequestWithAdditionalFields struct for PostgreSQL compatibility.
  • It reorganizes existing fields in the struct to ensure proper alignment.
  • These changes aim to improve the database interaction capabilities of the application.
  • Overall, the pull request introduces changes to the UserDeploymentRequestWithAdditionalFields struct, enhancing compatibility with PostgreSQL.

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@gitguardian

gitguardian Bot commented Dec 16, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2763127 Triggered Generic High Entropy Secret e96e929 scripts/devtron-reference-helm-charts/reference-chart_5-2-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret e96e929 scripts/devtron-reference-helm-charts/reference-chart_5-2-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@Ash-exp Ash-exp changed the title fix: update UserDeploymentRequestWithAdditionalFields struct to include tableName for PostgreSQL compatibility misc: update UserDeploymentRequestWithAdditionalFields struct to include tableName for PostgreSQL compatibility Dec 16, 2025
@sonarqubecloud

Copy link
Copy Markdown

@Ash-exp Ash-exp merged commit 8bfeec8 into main Dec 16, 2025
11 of 12 checks passed
@Ash-exp Ash-exp deleted the fix/async-helm-deploy branch December 16, 2025 12:43
@bito-code-review

Copy link
Copy Markdown

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants