misc: Custom chart fix oss#6956
Merged
Merged
Conversation
…g manifest generation **Details**: - Introduced `mergeReleaseOverrideIntoValuesYaml` method to handle JSON patching of `ReleaseOverride` into values YAML. - Updated `DeploymentTemplateServiceImpl` to integrate the new merge logic. - Added `ReleaseOverride` field to chart beans and updated adaptors for consistent data handling. - Resolved import ordering issues in multiple files.
…pp chart **Details**: - Modified `patchReleaseAttributes` to read `release-values.yaml` and `.image_descriptor_template.json` directly from the reference chart directory. - Added helper methods to handle file discovery and fallback logic for reference chart overrides. - Updated `resolveImageDescriptorTemplate` to handle missing DB entries using reference chart files. - Removed unused `ReleaseOverride` field from chart beans and adaptors.
prakash100198
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
Bito Automatic Review Skipped - Branch Excluded |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
vikramdevtron
approved these changes
Apr 24, 2026
github-actions
Bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?