Skip to content

Prepare NuGet publication metadata for Generators and Abstractions packages #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dex3r merged 2 commits into from
Mar 4, 2026
Merged

Prepare NuGet publication metadata for Generators and Abstractions packages #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b9b14
Initial plan
Copilot Mar 3, 2026
1173938
chore: add nuget package metadata for publication prep
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions MattSourceGenHelpers.Abstractions/MattSourceGenHelpers.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,23 @@
<LangVersion>default</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

Copilot AI Mar 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeneratePackageOnBuild is now enabled unconditionally for this library, which means dotnet build/dotnet test in CI will also run packing and emit .nupkg files as a side effect. If the intent is only to produce packages for releases, consider conditioning this on $(Configuration) == Release (or removing it and packing explicitly in a release workflow) to avoid extra work and potential pack-time warnings breaking local/CI builds.

Suggested change
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<GeneratePackageOnBuild Condition="'$(Configuration)' == 'Release'">true</GeneratePackageOnBuild>

Copilot uses AI. Check for mistakes.
<Version>0.1.0</Version>
<Title>Matt Source Generation Helpers Abstractions</Title>
<Description>Attributes and fluent abstractions used by MattSourceGenHelpers source generators.</Description>
<Authors>Matt Krzaczek</Authors>
<PackageProjectUrl>https://github.com/dex3r/MattSourceGenHelpers</PackageProjectUrl>
<RepositoryUrl>https://github.com/dex3r/MattSourceGenHelpers</RepositoryUrl>
<PackageReadmeFile>README.md</PackageReadmeFile>
Comment on lines +8 to +14

Copilot AI Mar 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package metadata like Version, Authors, and repository URLs are now duplicated across projects, which can easily drift over time (e.g., one package version gets bumped but the other doesn't). Consider centralizing shared NuGet metadata (e.g., in a Directory.Build.props) and keeping only package-specific fields (like Description) in each .csproj.

Suggested change
<Version>0.1.0</Version>
<Title>Matt Source Generation Helpers Abstractions</Title>
<Description>Attributes and fluent abstractions used by MattSourceGenHelpers source generators.</Description>
<Authors>Matt Krzaczek</Authors>
<PackageProjectUrl>https://github.com/dex3r/MattSourceGenHelpers</PackageProjectUrl>
<RepositoryUrl>https://github.com/dex3r/MattSourceGenHelpers</RepositoryUrl>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Title>Matt Source Generation Helpers Abstractions</Title>
<Description>Attributes and fluent abstractions used by MattSourceGenHelpers source generators.</Description>

Copilot uses AI. Check for mistakes.
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2025.2.4" />
</ItemGroup>

<ItemGroup>
<None Include="..\README.md" Pack="true" PackagePath="\" />
</ItemGroup>

</Project>
6 changes: 6 additions & 0 deletions MattSourceGenHelpers.Generators/MattSourceGenHelpers.Generators.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Version>0.1.0</Version>
<Title>Matt Source Generation Helpers</Title>
<Description>Roslyn source generators that turn normal methods into generated implementations.</Description>
<Authors>Matt Krzaczek</Authors>
<PackageProjectUrl>https://github.com/dex3r/MattSourceGenHelpers</PackageProjectUrl>
<RepositoryUrl>https://github.com/dex3r/MattSourceGenHelpers</RepositoryUrl>
<PackageReadmeFile>README.md</PackageReadmeFile>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

Expand All @@ -22,4 +24,8 @@
<ItemGroup>
<ProjectReference Include="..\MattSourceGenHelpers.Abstractions\MattSourceGenHelpers.Abstractions.csproj" />
</ItemGroup>

<ItemGroup>
<None Include="..\README.md" Pack="true" PackagePath="\" />
</ItemGroup>
</Project>