Skip to content

Commit cc648ec

Browse files
taylorsilvaCI Bot
authored andcommitted
update cf connector to use slog instead
Signed-off-by: Taylor Silva <dev@taydev.net>
1 parent d03f900 commit cc648ec

2 files changed

Lines changed: 11 additions & 16 deletions

File tree

connector/cloudfoundry/cloudfoundry.go

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"encoding/json"
88
"errors"
99
"fmt"
10+
"log/slog"
1011
"net"
1112
"net/http"
1213
"os"
@@ -17,7 +18,6 @@ import (
1718
"golang.org/x/oauth2"
1819

1920
"github.com/dexidp/dex/connector"
20-
"github.com/dexidp/dex/pkg/log"
2121
)
2222

2323
type cloudfoundryConnector struct {
@@ -29,7 +29,7 @@ type cloudfoundryConnector struct {
2929
authorizationURL string
3030
userInfoURL string
3131
httpClient *http.Client
32-
logger log.Logger
32+
logger *slog.Logger
3333
}
3434

3535
type connectorData struct {
@@ -106,7 +106,7 @@ type login struct {
106106
Href string `json:"href"`
107107
}
108108

109-
func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error) {
109+
func (c *Config) Open(id string, logger *slog.Logger) (connector.Connector, error) {
110110
var err error
111111

112112
cloudfoundryConn := &cloudfoundryConnector{
@@ -125,16 +125,14 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
125125
apiURL := strings.TrimRight(c.APIURL, "/")
126126
apiResp, err := cloudfoundryConn.httpClient.Get(apiURL)
127127
if err != nil {
128-
logger.Errorf("failed-to-send-request-to-cloud-controller-api", err)
129-
return nil, err
128+
return nil, fmt.Errorf("failed-to-send-request-to-cloud-controller-api: %w", err)
130129
}
131130

132131
defer apiResp.Body.Close()
133132

134133
if apiResp.StatusCode != http.StatusOK {
135134
err = fmt.Errorf("request failed with status %d", apiResp.StatusCode)
136-
logger.Errorf("failed-get-info-response-from-api", err)
137-
return nil, err
135+
return nil, fmt.Errorf("failed-get-info-response-from-api: %w", err)
138136
}
139137

140138
var apiResult infoResp
@@ -144,14 +142,12 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
144142
uaaURL := strings.TrimRight(apiResult.Links.Login.Href, "/")
145143
uaaResp, err := cloudfoundryConn.httpClient.Get(fmt.Sprintf("%s/.well-known/openid-configuration", uaaURL))
146144
if err != nil {
147-
logger.Errorf("failed-to-send-request-to-uaa-api", err)
148-
return nil, err
145+
return nil, fmt.Errorf("failed-to-send-request-to-uaa-api: %w", err)
149146
}
150147

151148
if apiResp.StatusCode != http.StatusOK {
152149
err = fmt.Errorf("request failed with status %d", apiResp.StatusCode)
153-
logger.Errorf("failed-to-get-well-known-config-response-from-api", err)
154-
return nil, err
150+
return nil, fmt.Errorf("failed-to-get-well-known-config-response-from-api: %w", err)
155151
}
156152

157153
defer uaaResp.Body.Close()
@@ -160,8 +156,7 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
160156
err = json.NewDecoder(uaaResp.Body).Decode(&uaaResult)
161157

162158
if err != nil {
163-
logger.Errorf("failed-to-decode-response-from-uaa-api", err)
164-
return nil, err
159+
return nil, fmt.Errorf("failed-to-decode-response-from-uaa-api: %w", err)
165160
}
166161

167162
cloudfoundryConn.tokenURL, _ = uaaResult["token_endpoint"].(string)

connector/cloudfoundry/cloudfoundry_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import (
44
"encoding/json"
55
"errors"
66
"fmt"
7+
"io"
8+
"log/slog"
79
"net/http"
810
"net/http/httptest"
911
"reflect"
1012
"strings"
1113
"testing"
1214

13-
"github.com/sirupsen/logrus"
14-
1515
"github.com/dexidp/dex/connector"
1616
)
1717

@@ -510,7 +510,7 @@ func newConnector(t *testing.T, serverURL string) *cloudfoundryConnector {
510510
InsecureSkipVerify: true,
511511
}
512512

513-
log := logrus.New()
513+
log := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{}))
514514

515515
conn, err := testConfig.Open("id", log)
516516
if err != nil {

0 commit comments

Comments
 (0)