fix: add dedicated go.mod for /v2 to fix /v2 imports#4370
Conversation
…g backward compatibility Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
|
@nabokihms Hi! Can you review this simple PR which fixed go mod v2 compatibility? |
|
Hey @nabokihms. Is there anything I can do to move this forward? |
|
@TylerGillson I will test this PR, missed it completely. If standard go tooling works from the root, it seems ok, but maybe we need just to migrate imports... I will test and return back with the verdict. |
|
Ok, I tested. It seems like we cannot move forward with this PR.
If we want to properly solve the problem with v2, I would like to solve it the right way, but it is a big breaking change for many |
|
@nabokihms you’re right.. my apologies. I’ll close this PR. A The root issue here is that dex uses There are three options:
|
Overview
Applies the major version subdirectory approach to fixing dex's currently broken usage of major version release tags without a corresponding major version in go.mod.
This approach maintains backward compatibility with current projects importing pseudo versions.
What this PR does / why we need it
Closes #4222
Special notes for your reviewer
govulncheckshould stop flagging https://pkg.go.dev/vuln/GO-2024-2476#versions-note once this is merged and a new release is published.