Skip to content

Commit 0828efc

Browse files
authored
chore: remove internal short-code markers from test comments (#88)
PR: #88
1 parent daff797 commit 0828efc

13 files changed

Lines changed: 22 additions & 23 deletions

File tree

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/auth/DigestChallengeHandlerTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ class DigestChallengeHandlerTest {
788788
assertEquals(threadCount * iterationsPerThread, collected.max())
789789
}
790790

791-
// ---- AtomicLong overflow safety (H4) ----------------------------------------
791+
// ---- AtomicLong overflow safety ----------------------------------------
792792

793793
@Test
794794
fun `nc counter past Int MAX_VALUE stays positive and well-formed`() {

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/pipeline/steps/AsyncInstrumentationStepTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ class AsyncInstrumentationStepTest {
364364

365365
@Test
366366
fun `http_response event carries trace_id from MDC set by span scope`() {
367-
// B5: verify that the response event captured by FakeSlf4jLogger carries trace.id.
367+
// Verify that the response event captured by FakeSlf4jLogger carries trace.id.
368368
// We set up MDC before the pipeline call so the MdcSnapshot capture inside the
369369
// use{} block picks up the trace.id installed by the span's makeCurrentWithLoggingContext.
370370
installBasicMdcAdapter()
@@ -403,7 +403,7 @@ class AsyncInstrumentationStepTest {
403403

404404
@Test
405405
fun `processAsync handles a synchronous throw from next as a failed future`() {
406-
// B13: a next step whose processAsync throws synchronously must be normalised to a
406+
// A next step whose processAsync throws synchronously must be normalised to a
407407
// failed future; failure event emitted; span ended with the throwable.
408408
val fakeSlf4j = FakeSlf4jLogger("test.async.sync.throw")
409409
val clientLogger = ClientLogger.forTesting(fakeSlf4j)

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/pipeline/steps/BearerTokenAuthStepTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ class BearerTokenAuthStepTest {
2828
private val nowInstant: Instant = Instant.parse("2026-01-01T12:00:00Z")
2929
private val clock = FixedClock(nowInstant)
3030

31-
// ---- B14: fresh-token validation does NOT apply refreshMargin ----
31+
// ---- fresh-token validation does NOT apply refreshMargin ----
3232

3333
/**
34-
* B14: A provider that returns a token whose expiresAt is within the refreshMargin of
34+
* A provider that returns a token whose expiresAt is within the refreshMargin of
3535
* `now` is considered misbehaving — it minted a token that would immediately be treated
3636
* as expired on the next request. The [BearerTokenAuthStep] must throw
3737
* [IllegalStateException] even though the token is technically not yet expired (it is

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/pipeline/steps/RedirectStepTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -941,7 +941,7 @@ class RedirectStepTest {
941941

942942
@Test
943943
fun `stripping userinfo preserves percent-encoding in path and query`() {
944-
// L3: clearing the userinfo must not re-encode the Location. A path segment carrying
944+
// Clearing the userinfo must not re-encode the Location. A path segment carrying
945945
// %2F and a query value carrying %26 must survive verbatim — rebuilding via URI's
946946
// decoded multi-arg constructor would turn %2F into '/' and %26 into '&', silently
947947
// changing the path/query structure of the reissued request.

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/pipeline/steps/RetryStepTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,7 +1031,7 @@ class RetryStepTest {
10311031

10321032
@Test
10331033
fun `throwing shouldRetryCondition closes the retryable response before propagating`() {
1034-
// M6: the should-retry predicate runs while the retryable response is still open. If it
1034+
// The should-retry predicate runs while the retryable response is still open. If it
10351035
// throws, the response must be closed before the exception propagates — otherwise the
10361036
// 5xx response's socket/buffer leaks. Assert both the close() is observed and the
10371037
// exception still surfaces.
@@ -1063,7 +1063,7 @@ class RetryStepTest {
10631063

10641064
@Test
10651065
fun `throwing computeResponseDelay override closes the retryable response before propagating`() {
1066-
// M6: a subclass override of computeResponseDelay runs after the predicate approves the
1066+
// A subclass override of computeResponseDelay runs after the predicate approves the
10671067
// retry, while the response is still open. If it throws, the response must be closed
10681068
// before the exception propagates.
10691069
val closes = AtomicInteger(0)

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/response/LoggableResponseBodyTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class LoggableResponseBodyTest {
5252
}
5353
}
5454

55-
// ----- H2: source() that throws before entering .use {} -----
55+
// ----- source() that throws before entering .use {} -----
5656

5757
@Test
5858
fun `when delegate source() itself throws close() still closes the delegate`() {
@@ -166,7 +166,7 @@ class LoggableResponseBodyTest {
166166
)
167167
}
168168

169-
// ----- A12: additional failure-semantics tests -----
169+
// ----- additional failure-semantics tests -----
170170

171171
@Test
172172
fun `source() after drainError is set re-throws the cached exception`() {
@@ -271,7 +271,7 @@ class LoggableResponseBodyTest {
271271
)
272272
}
273273

274-
// ----- H1: bounded capture + live-tail behavior -----
274+
// ----- bounded capture + live-tail behavior -----
275275

276276
@Test
277277
fun `over-cap body returns the full bytes to the consumer while snapshot is bounded`() {

sdk-core/src/test/kotlin/org/dexpace/sdk/core/http/sse/ServerSentEventExtensionsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class ServerSentEventExtensionsTest {
2525

2626
private fun source(text: String): BufferedSource = Io.provider.source(text.toByteArray(Charsets.UTF_8))
2727

28-
// ----- A13 cases -----
28+
// ----- readServerSentEvents() sequence behavior -----
2929

3030
@Test
3131
fun `valid stream of two events yields the expected ServerSentEvent sequence`() {

sdk-core/src/test/kotlin/org/dexpace/sdk/core/instrumentation/LoggingEventTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ class LoggingEventTest {
616616
assertContains(rendered, "anon-msg")
617617
}
618618

619-
// -- MDC allow-list (B9) ------------------------------------------------------------------
619+
// -- MDC allow-list ------------------------------------------------------------------
620620

621621
@Test
622622
fun `default allow-list folds only trace_id and span_id from MDC`() {

sdk-core/src/test/kotlin/org/dexpace/sdk/core/io/TeeSinkTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ class TeeSinkTest {
256256
assertContentEquals("2345".toByteArray(), tap.snapshot())
257257
}
258258

259-
// ----- M4: bounded tap (tapLimit) -----
259+
// ----- bounded tap (tapLimit) -----
260260

261261
@Test
262262
fun `tapLimit caps the tap but forwards the full payload to primary - typed write`() {

sdk-core/src/test/kotlin/org/dexpace/sdk/core/util/FuturesTest.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,8 @@ class FuturesTest {
6161

6262
@Test
6363
fun `unwrap walks an arbitrarily-deep wrapper chain to the leaf`() {
64-
// 20 levels: matches the deep-chain test pattern in RetryUtilsTest after M4 removed
65-
// the MAX_DEPTH cap. The HashSet-based cycle guard replaces the depth cap, so a
66-
// long-but-acyclic chain unwraps fully to the IOException leaf.
64+
// 20 levels: unwrap has no fixed depth cap — a HashSet-based cycle guard replaces any
65+
// MAX_DEPTH limit, so a long-but-acyclic chain unwraps fully to the IOException leaf.
6766
val leaf = IOException("leaf")
6867
var current: Throwable = leaf
6968
repeat(20) { current = CompletionException("wrap-$it", current) }

0 commit comments

Comments
 (0)