#3 Result-based error handling#39
Merged
Merged
Conversation
- Add error.rs with ActionError enum (MissingEnv, InvalidStrategy, InvalidTag, Unauthorized, ApiError, UnexpectedStatus) - config.rs: all helpers return Result; Config::new() returns Result<Config, ActionError>; remove Default impl - releases.rs: get_latest_release and create_release return Result<Option<TagName>, ActionError>; fix lifetime annotation - main.rs: run() -> Result bubbles errors up; main() has the single eprintln + exit(1) - README: drop ?branch=main from badge URL so it reflects latest run Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error.rs—ActionErrorenum with variants:MissingEnv,InvalidStrategy,InvalidTag,Unauthorized,ApiError,UnexpectedStatusconfig.rs— all env-reading helpers returnResult;Config::new()returnsResult<Config, ActionError>;Defaultimpl removed;exit(1)gonereleases.rs—get_latest_releaseandcreate_releasereturnResult<Option<TagName>, ActionError>; lifetime annotation correctedmain.rs—run() -> Result<(), ActionError>contains all logic;main()is the single site foreprintln! + exit(1)?branch=mainfrom badge URL (fixes stale badge)This is the prerequisite for #4 (unit tests for config and releases).
Test plan
cargo test— 6 tests, all green🤖 Generated with Claude Code