Add WithColour, WithAxis, and WithFacing in blocks#1183
Open
AkmalFairuz wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
WithColour,WithAxis, andWithFacingsupport for blocks so we can properly handle state-aware transformations in the WorldEdit server. The main use case is implementing a//rotatecommand that rotates selected regions while preserving block properties. Rotation only applies to blocks that depend on orientation, specifically those using Axis and Facing. By exposing these modifiers directly on the block interface, we can transform block states cleanly and deterministically during region edits without relying on hardcoded type switches.Previously, the alternative approach relied on
reflectto modify block state dynamically. That worked functionally, but the performance overhead was noticeable, especially when rotating large selections. Reflection adds unnecessary runtime cost and reduces type safety. With explicitWithAxisandWithFacingmethods, rotation becomes faster.Example: