imeplement concurrent chunk generation#1216
Open
FDUTCH wants to merge 15 commits into
Open
Conversation
Contributor
Author
|
okay, now it feels really stable |
Contributor
Author
|
should I also call world.Provider asynchronously? |
Collaborator
|
take reference from this PR for some things HashimTheArab#7 |
Contributor
Author
I don't really like how this is done in your brunch:
I was planing to make pr in the future that will allow you to swap low level systems of the world to your own, like how world is handling ticks, chunk requests and such... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements concurrent chunk generation with no additional locks.
But it is not ready for production use and it requires testing on a multiplayer server.
PS. No AI was used...