manual fix of ServiceLoader

Encoding was provided both as module-info and as
a file...and both files were not aligned.

The real fix was to write a failing (see EncodingRegistryTest) that makes sure that all
encoding are really registered properly.

Dropped 3 EncodingId without any Encoding:
- VORTEX_BITPACKED("vortex.bitpacked")
- VORTEX_FLAT("vortex.flat")
- VORTEX_STATS("vortex.stats")

So after testing with module-info and "provides/uses" keyword csv was still failing.
So the solution for now is to revert back to
the classpath (see TODO item).

Author: dfa1

TODO.md

@@ -77,6 +77,7 @@
 - [ ] prefix all modules with "vortex-"
 - [ ] add BOM module
 - [ ] deploy to maven central
+- [ ] switch back to module-path, but keep in mind these 2 blockers
 - [ ] drop warnings about flatbuffers
 ```shell
 [WARNING] ****************************************************************************************************************************************************

core/src/main/java/io/github/dfa1/vortex/encoding/EncodingId.java

@@ -17,7 +17,6 @@ public enum EncodingId {
 	VORTEX_RUNEND("vortex.runend"),
 	VORTEX_CONSTANT("vortex.constant"),
 	VORTEX_ALP("vortex.alp"),
-	VORTEX_BITPACKED("vortex.bitpacked"),
 	VORTEX_VARBIN("vortex.varbin"),
 	VORTEX_FSST("vortex.fsst"),
 	VORTEX_NULL("vortex.null"),
@@ -36,10 +35,8 @@ public enum EncodingId {
 	VORTEX_ALPRD("vortex.alprd"),
 
 	// Layout encoding IDs included so parser/registry can represent them safely
-	VORTEX_FLAT("vortex.flat"),
 	VORTEX_CHUNKED("vortex.chunked"),
 	VORTEX_STRUCT("vortex.struct"),
-	VORTEX_STATS("vortex.stats"),
 
 	FASTLANES_BITPACKED("fastlanes.bitpacked"),
 	FASTLANES_FOR("fastlanes.for"),

core/src/main/java/io/github/dfa1/vortex/encoding/EncodingRegistry.java

@@ -100,11 +100,10 @@ public Array decodeSegment(MemorySegment seg, List<String> encodingSpecs,
 
 	Array decode(DecodeContext ctx) {
 		EncodingId id = ctx.node().encodingId();
-		Encoding c = encodings.get(id);
-		if (c == null) {
-			System.out.println(encodings);
+		Encoding encoding = encodings.get(id);
+		if (encoding == null) {
 			throw new VortexException(id, "no encoding registered");
 		}
-		return c.decode(ctx);
+		return encoding.decode(ctx);
 	}
 }

core/src/main/java/module-info.java

@@ -32,10 +32,7 @@ void all() {
 
 		// When
 		for (EncodingId encodingId : EncodingId.values()) {
-			if (!sut.hasEncoding(encodingId)) {
-				System.out.println(encodingId);
-			}
-			//assertThat(sut.hasEncoding(encodingId)).describedAs("%s".formatted(encodingId)).isTrue();
+			assertThat(sut.hasEncoding(encodingId)).describedAs("%s".formatted(encodingId)).isTrue();
 		}
 	}
 }

core/src/test/java/io/github/dfa1/vortex/encoding/EncodingRegistryTest.java

@@ -278,7 +278,7 @@ private Array decodeConcatPrimitive(List<Layout> flats, DType dtype, long totalR
 
 	private Array decodeFlat(Layout flat, DType dtype, SegmentAllocator arena) {
 		if (flat.segments().isEmpty()) {
-			throw new VortexException(EncodingId.VORTEX_FLAT, "no segments");
+			throw new VortexException("no segments");
 		}
 		int segIdx = flat.segments().getFirst();
 		SegmentSpec spec = file.footer().segmentSpecs().get(segIdx);