manual sonar fixes

Author: dfa1

csv/src/test/java/io/github/dfa1/vortex/csv/CsvExporterTest.java

@@ -425,7 +425,7 @@ void rendersStructInStructAsNestedJsonObject(@TempDir Path tmp) throws Exception
 
     @Test
     void rendersFixedSizeListColumnAsJsonArray(@TempDir Path tmp) throws Exception {
-        // Given a FixedSizeList[F32, 3] column — the glove vector shape (issue #257);
+        // Given a FixedSizeList of type F32 and size 3 column — the glove vector shape (issue #257);
         // each row is 3 consecutive floats from the flat elements array.
         Path vortex = tmp.resolve("fsl.vortex");
         DType.FixedSizeList vecDtype = new DType.FixedSizeList(DType.F32, 3, false);

integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudConformanceIntegrationTest.java

@@ -190,7 +190,7 @@ private static void assertMatchesParquetOracle(Path vortex, Path parquet) throws
     private static void closeQuietly(Closeable closeable) {
         try {
             closeable.close();
-        } catch (IOException ignored) {
+        } catch (IOException _) {
             // best effort: only used to unblock a producer thread before join()
         }
     }

integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudSizeComparisonIntegrationTest.java

@@ -12,7 +12,7 @@
 import java.nio.file.Path;
 import java.util.stream.Stream;
 
-import static org.junit.jupiter.api.Assumptions.assumeTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /// File-size comparison across the Raincloud corpus for three representations:
 /// Parquet (corpus oracle), vortex-jni (corpus file, written by Rust Vortex), and
@@ -33,7 +33,7 @@ class RaincloudSizeComparisonIntegrationTest {
     @Test
     void corpusIsHydrated() {
         // Given / When / Then — visible skip marker when the corpus is absent
-        assumeTrue(Files.exists(manifestPath()),
+        assertTrue(Files.exists(manifestPath()),
                 "raincloud corpus not hydrated — run scripts/hydrate-raincloud-corpus.sh");
     }
 

jdbc/src/test/java/io/github/dfa1/vortex/jdbc/JdbcImporterTest.java

@@ -27,6 +27,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+@SuppressWarnings("SqlNoDataSourceInspection")
 class JdbcImporterTest {
 
     private Connection conn;
@@ -177,10 +178,10 @@ void roundTripsNullableExtensionColumns(@TempDir Path tmp) throws Exception {
             try (VortexReader reader = VortexReader.open(vortex,
                     io.github.dfa1.vortex.reader.ReadRegistry.loadAll())) {
                 DType.Struct schema = (DType.Struct) reader.dtype();
-                assertThat(((DType.Extension) schema.fieldTypes().get(1)).nullable()).isTrue();
-                assertThat(((DType.Extension) schema.fieldTypes().get(2)).nullable()).isTrue();
-                assertThat(((DType.Extension) schema.fieldTypes().get(3)).nullable()).isTrue();
-                assertThat(((DType.Extension) schema.fieldTypes().get(4)).nullable()).isTrue();
+                assertThat(schema.fieldTypes().get(1).nullable()).isTrue();
+                assertThat(schema.fieldTypes().get(2).nullable()).isTrue();
+                assertThat(schema.fieldTypes().get(3).nullable()).isTrue();
+                assertThat(schema.fieldTypes().get(4).nullable()).isTrue();
 
                 try (ScanIterator iter = reader.scan(ScanOptions.all())) {
                     assertThat(iter.hasNext()).isTrue();
@@ -389,7 +390,7 @@ void progressListenerIsInvokedPerChunk(@TempDir Path tmp) throws Exception {
             List<Long> checkpoints = new ArrayList<>();
             JdbcImportOptions options = JdbcImportOptions.defaults()
                                                 .withChunkSize(3)
-                                                .withProgressListener((done, total) -> checkpoints.add(done));
+                                                .withProgressListener((done, _) -> checkpoints.add(done));
 
             // When
             JdbcImporter.importQuery(conn, "SELECT * FROM progress_test", vortex, options);

reader/src/main/java/io/github/dfa1/vortex/reader/ScanIterator.java

@@ -77,7 +77,6 @@
 /// ```
 public final class ScanIterator implements Iterator<Chunk>, AutoCloseable {
 
-
     private final VortexHandle file;
     private final ScanOptions options;
 
@@ -791,8 +790,7 @@ private static Array sliceArray(Array full, long offset, long length, DType dtyp
                 // window's absolute position rather than shared unchanged.
                 DType.FixedSizeList fd = (DType.FixedSizeList) dtype;
                 int fixedSize = a.fixedSize();
-                Array elementsSlice = sliceArray(a.elements(), offset * (long) fixedSize,
-                        length * (long) fixedSize, fd.elementType());
+                Array elementsSlice = sliceArray(a.elements(), offset * fixedSize, length *fixedSize, fd.elementType());
                 yield new FixedSizeListArray(fd, length, elementsSlice);
             }
             default -> throw new VortexException(