Commit 512cfbd
Two silent-null-loss bugs surfaced by Raincloud conformance triage round 4,
both the same class as #210 (validity dropped when unwrapping a MaskedArray
child). Fixed by re-wrapping the decoded result in a MaskedArray whose per-row
validity mirrors the Rust reference vtables — expressed lazily, O(runs)/O(patches)
not O(rows), since n can be huge (uci-online-retail has 499712 rows).
RunEnd (#225): a nullable run-value dropped its mask, so a null run expanded to
a filler value (uci-online-retail `customerid` u16?: null rows emitted the FoR
base). Per Rust `ValidityVTable<RunEnd>`, a RunEnd array's validity IS a RunEnd
over the same ends whose per-run value is the run-value's validity bit; a row's
validity is thus the validity of the run it falls in. Implemented as
`LazyRunEndBoolArray(ends, values-validity, offset)`.
Sparse (#226), two facets. Null fill was coerced to 0 (`scalarToLong` returns 0
for a null scalar), so a `fill_value: null` array decoded every unpatched
position as 0.0 (world-energy-consumption `biofuel_cons_change_pct` f64?).
Nullable patch values were stripped, so a patched-but-null position decoded to
raw 0 (nuclear_share_energy). Per Rust `ValidityVTable<Sparse>`, row validity is
a sparse bool whose fill is `fill_value.is_valid()` and whose per-patch value is
the patch value's validity bit — so a position is valid iff (it is a patch AND
that patch is valid) OR (it is unpatched AND the fill is non-null). Null fill is
detected from the ScalarValue (explicit null_value or no value-bearing field set),
not from `scalarToLong`'s lossy 0.
Corpus evidence: both slugs now match their Parquet oracle value-for-value
(uci-online-retail 4335272 cells, world-energy-consumption 3039010 cells);
expected-status.csv flips both gap entries to ok.
Closes #225
Closes #226
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 9b66746 commit 512cfbd
8 files changed
Lines changed: 454 additions & 42 deletions
File tree
- docs
- integration/src/test/resources/raincloud
- reader/src
- main/java/io/github/dfa1/vortex/reader/decode
- test/java/io/github/dfa1/vortex/reader/decode
- writer/src/test/java/io/github/dfa1/vortex/writer/encode
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 65 | + | |
69 | 66 | | |
70 | 67 | | |
71 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
72 | 71 | | |
73 | 72 | | |
74 | 73 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
222 | | - | |
| 222 | + | |
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
Lines changed: 42 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
58 | 74 | | |
59 | 75 | | |
60 | | - | |
61 | | - | |
62 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
63 | 80 | | |
64 | 81 | | |
65 | 82 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 83 | + | |
| 84 | + | |
70 | 85 | | |
71 | 86 | | |
72 | 87 | | |
| |||
77 | 92 | | |
78 | 93 | | |
79 | 94 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 95 | + | |
84 | 96 | | |
85 | 97 | | |
86 | 98 | | |
87 | 99 | | |
88 | 100 | | |
89 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
90 | 121 | | |
91 | 122 | | |
92 | 123 | | |
| |||
Lines changed: 81 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
66 | 78 | | |
67 | 79 | | |
68 | 80 | | |
69 | 81 | | |
70 | 82 | | |
71 | | - | |
72 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
73 | 92 | | |
74 | 93 | | |
75 | 94 | | |
76 | 95 | | |
77 | 96 | | |
78 | 97 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | 98 | | |
88 | 99 | | |
89 | 100 | | |
| |||
93 | 104 | | |
94 | 105 | | |
95 | 106 | | |
96 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
97 | 113 | | |
98 | | - | |
| 114 | + | |
99 | 115 | | |
100 | 116 | | |
101 | 117 | | |
| |||
114 | 130 | | |
115 | 131 | | |
116 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
117 | 186 | | |
118 | 187 | | |
119 | 188 | | |
| |||
0 commit comments